public inbox for java-prs@sourceware.org help / color / mirror / Atom feed
* [Bug java/28090] New: incorrect implementation of expand_java_arraystore
@ 2006-06-19 23:07 tromey at gcc dot gnu dot org
2006-06-20 17:37 ` [Bug java/28090] " pinskia at gcc dot gnu dot org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: tromey at gcc dot gnu dot org @ 2006-06-19 23:07 UTC (permalink / raw)
To: java-prs
According to the ArrayStore.java test case, bounds checks should
take precedence over array store checks. However, expand_java_arraystore
clearly does it in the wrong order:
if (TREE_CODE (rhs_type_node) == POINTER_TYPE)
{
tree check = build_java_arraystore_check (array, rhs_node);
java_add_stmt (check);
}
array = build_java_arrayaccess (array, rhs_type_node, index);
--
Summary: incorrect implementation of expand_java_arraystore
Product: gcc
Version: 4.2.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: java
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: tromey at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug java/28090] incorrect implementation of expand_java_arraystore 2006-06-19 23:07 [Bug java/28090] New: incorrect implementation of expand_java_arraystore tromey at gcc dot gnu dot org @ 2006-06-20 17:37 ` pinskia at gcc dot gnu dot org 2006-06-20 17:42 ` tromey at gcc dot gnu dot org ` (5 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: pinskia at gcc dot gnu dot org @ 2006-06-20 17:37 UTC (permalink / raw) To: java-prs ------- Comment #1 from pinskia at gcc dot gnu dot org 2006-06-20 17:37 ------- Confirmed. -- pinskia at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Keywords| |wrong-code Last reconfirmed|0000-00-00 00:00:00 |2006-06-20 17:37:38 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug java/28090] incorrect implementation of expand_java_arraystore 2006-06-19 23:07 [Bug java/28090] New: incorrect implementation of expand_java_arraystore tromey at gcc dot gnu dot org 2006-06-20 17:37 ` [Bug java/28090] " pinskia at gcc dot gnu dot org @ 2006-06-20 17:42 ` tromey at gcc dot gnu dot org 2006-06-20 20:22 ` tromey at gcc dot gnu dot org ` (4 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: tromey at gcc dot gnu dot org @ 2006-06-20 17:42 UTC (permalink / raw) To: java-prs ------- Comment #2 from tromey at gcc dot gnu dot org 2006-06-20 17:42 ------- Created an attachment (id=11712) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11712&action=view) proposed patch I've attached a proposed patch. However, when I use this patch I run into PR 19505. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug java/28090] incorrect implementation of expand_java_arraystore 2006-06-19 23:07 [Bug java/28090] New: incorrect implementation of expand_java_arraystore tromey at gcc dot gnu dot org 2006-06-20 17:37 ` [Bug java/28090] " pinskia at gcc dot gnu dot org 2006-06-20 17:42 ` tromey at gcc dot gnu dot org @ 2006-06-20 20:22 ` tromey at gcc dot gnu dot org 2006-07-18 15:12 ` tromey at gcc dot gnu dot org ` (3 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: tromey at gcc dot gnu dot org @ 2006-06-20 20:22 UTC (permalink / raw) To: java-prs -- tromey at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|unassigned at gcc dot gnu |tromey at gcc dot gnu dot |dot org |org Status|NEW |ASSIGNED Last reconfirmed|2006-06-20 17:37:38 |2006-06-20 20:22:21 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug java/28090] incorrect implementation of expand_java_arraystore 2006-06-19 23:07 [Bug java/28090] New: incorrect implementation of expand_java_arraystore tromey at gcc dot gnu dot org ` (2 preceding siblings ...) 2006-06-20 20:22 ` tromey at gcc dot gnu dot org @ 2006-07-18 15:12 ` tromey at gcc dot gnu dot org 2006-09-13 10:10 ` bonzini at gnu dot org ` (2 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: tromey at gcc dot gnu dot org @ 2006-07-18 15:12 UTC (permalink / raw) To: java-prs ------- Comment #3 from tromey at gcc dot gnu dot org 2006-07-18 15:12 ------- FWIW compiling from bytecode on svn head fails as well. In fact the test case is xfailed in this case. So this doesn't appear to be a regression. Also I think this patch is bogus (but at least it shows the right place to add the fix). -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug java/28090] incorrect implementation of expand_java_arraystore 2006-06-19 23:07 [Bug java/28090] New: incorrect implementation of expand_java_arraystore tromey at gcc dot gnu dot org ` (3 preceding siblings ...) 2006-07-18 15:12 ` tromey at gcc dot gnu dot org @ 2006-09-13 10:10 ` bonzini at gnu dot org 2006-12-21 15:09 ` aph at gcc dot gnu dot org 2007-01-09 20:37 ` tromey at gcc dot gnu dot org 6 siblings, 0 replies; 8+ messages in thread From: bonzini at gnu dot org @ 2006-09-13 10:10 UTC (permalink / raw) To: java-prs ------- Comment #4 from bonzini at gnu dot org 2006-09-13 10:10 ------- PR19505 is fixed, is the patch still bad? -- bonzini at gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bonzini at gnu dot org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug java/28090] incorrect implementation of expand_java_arraystore 2006-06-19 23:07 [Bug java/28090] New: incorrect implementation of expand_java_arraystore tromey at gcc dot gnu dot org ` (4 preceding siblings ...) 2006-09-13 10:10 ` bonzini at gnu dot org @ 2006-12-21 15:09 ` aph at gcc dot gnu dot org 2007-01-09 20:37 ` tromey at gcc dot gnu dot org 6 siblings, 0 replies; 8+ messages in thread From: aph at gcc dot gnu dot org @ 2006-12-21 15:09 UTC (permalink / raw) To: java-prs ------- Comment #5 from aph at gcc dot gnu dot org 2006-12-21 15:09 ------- I fixed PR19505 in July. Should not this patch go in? This is the last bug blocking 28067... -- aph at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aph at gcc dot gnu dot org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug java/28090] incorrect implementation of expand_java_arraystore 2006-06-19 23:07 [Bug java/28090] New: incorrect implementation of expand_java_arraystore tromey at gcc dot gnu dot org ` (5 preceding siblings ...) 2006-12-21 15:09 ` aph at gcc dot gnu dot org @ 2007-01-09 20:37 ` tromey at gcc dot gnu dot org 6 siblings, 0 replies; 8+ messages in thread From: tromey at gcc dot gnu dot org @ 2007-01-09 20:37 UTC (permalink / raw) To: java-prs ------- Comment #6 from tromey at gcc dot gnu dot org 2007-01-09 20:37 ------- Andrew's fix for this went in with the merge. -- tromey at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED Target Milestone|--- |4.3.0 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28090 ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2007-01-09 20:37 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2006-06-19 23:07 [Bug java/28090] New: incorrect implementation of expand_java_arraystore tromey at gcc dot gnu dot org 2006-06-20 17:37 ` [Bug java/28090] " pinskia at gcc dot gnu dot org 2006-06-20 17:42 ` tromey at gcc dot gnu dot org 2006-06-20 20:22 ` tromey at gcc dot gnu dot org 2006-07-18 15:12 ` tromey at gcc dot gnu dot org 2006-09-13 10:10 ` bonzini at gnu dot org 2006-12-21 15:09 ` aph at gcc dot gnu dot org 2007-01-09 20:37 ` tromey at gcc dot gnu dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).