[Bug java/33765] New: [4.3 regression] gcj internal compiler error when reading an empty file

[Bug java/33765] New: [4.3 regression] gcj internal compiler error when reading an empty file

[bero at arklinux dot org]

Feeding gcj an empty input file results in

[bero@localhost ~]$ rm -f crap.java ; touch crap.java ; gcj crap.java
/tmp/cck13U8f.jar:0: internal compiler error: in java_parse_file, at
java/jcf-parse.c:1951
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.


-- 
           Summary: [4.3 regression] gcj internal compiler error when
                    reading an empty file
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: bero at arklinux dot org
 GCC build triplet: i586-pc-linux-gnu
  GCC host triplet: i586-pc-linux-gnu
GCC target triplet: i586-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Keywords|                            |ice-on-valid-code
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[jakub at gcc dot gnu dot org]

------- Comment #1 from jakub at gcc dot gnu dot org  2007-10-28 15:47 -------
Created an attachment (id=14427)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14427&action=view)
gcc43-pr33765.patch

In this case (and e.g. also in case where you gcj -c package-info.java
from #297961) ecj1 creates an empty zip file, which contains just the
end central signature and nothing else (so doesn't have the usual
PK\3\4 magic, but PK\5\6).  The attached patch will handle it the same
as file with PK\3\4 magic, but it will still issue an error because the
expected
file wasn't found in the (empty) jar file.  Not sure what exact behavior we
want,
if giving an error is fine or if we e.g. should silently compile it into an
empty
.s file.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2007-10-30 14:28 -------
I have tried what icedtea javac does on such *.java files and it apparently
exits with 0 exit status, but doesn't create any *.class file.  So I guess
silently creating empty *.s (i.e. just ignore not being able to find the
expected class in the *.jar file created by ecj1) would match it best.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[tromey at gcc dot gnu dot org]

------- Comment #3 from tromey at gcc dot gnu dot org  2007-10-31 18:26 -------
Confirmed.

I would not mind giving an error for this.  We don't necessarily have
to be compatible with javac here.

I wonder, though, whether this is used in a configure script or something
like this.  How did the reporter happen across this case?


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-10-31 18:26:32
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[bero at arklinux dot org]

------- Comment #4 from bero at arklinux dot org  2007-10-31 18:36 -------
Unfortunately I don't remember what I was trying to compile, but I was trying
to compile some open source code I had downloaded. It was running javac on a
huge list of files, one of which was empty (probably to be implemented later).

So apparently some broken code using this javac "feature" exists.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[jakub at gcc dot gnu dot org]

------- Comment #5 from jakub at gcc dot gnu dot org  2007-10-31 23:42 -------
Well, package-info.java files containing just package something; line
and comments are quite common, and for them ecj1 creates an empty jar file.
If the whole package is compiled at once, then there will be a bigger jar file
and so this ICE or error won't trigger, but just letting gcj compile each
*.java
file into *.o individually in a makefile (using ecj1 internally) wouldn't work
in such cases.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[tromey at gcc dot gnu dot org]

------- Comment #6 from tromey at gcc dot gnu dot org  2007-11-01 19:24 -------
Created an attachment (id=14456)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14456&action=view)
patch to make it do nothing

This patch changes gcj to do nothing in this case.
It works fine on the test case.
Jakub, what do you think of this?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2007-11-02 08:02 -------
Looks good to me.  Andrew?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[aph at gcc dot gnu dot org]

------- Comment #8 from aph at gcc dot gnu dot org  2007-11-02 10:06 -------
I think it's brilliant!  I never expected such an elegant solution.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[tromey at gcc dot gnu dot org]

------- Comment #9 from tromey at gcc dot gnu dot org  2007-11-02 16:11 -------
Testing my patch.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tromey at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-10-31 18:26:32         |2007-11-02 16:11:58
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[tromey at gcc dot gnu dot org]

------- Comment #10 from tromey at gcc dot gnu dot org  2007-11-02 20:02 -------
Subject: Bug 33765

Author: tromey
Date: Fri Nov  2 20:02:35 2007
New Revision: 129860

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129860
Log:
        PR java/33765:
        * jcf-parse.c (java_parse_file): Ignore ZIPEMPTYMAGIC files.
        * zipfile.h (ZIPEMPTYMAGIC): New define.

Modified:
    trunk/gcc/java/ChangeLog
    trunk/gcc/java/jcf-parse.c
    trunk/gcc/java/zipfile.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765

[Bug java/33765] [4.3 regression] gcj internal compiler error when reading an empty file

[jakub at gcc dot gnu dot org]

------- Comment #11 from jakub at gcc dot gnu dot org  2007-11-02 20:08 -------
Fixed, thanks.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33765