public inbox for java-prs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: java-prs@gcc.gnu.org Subject: [Bug java/18190] [4.2/4.3/4.4 regression] primitive array optimization is gone Date: Fri, 20 Mar 2009 22:44:00 -0000 [thread overview] Message-ID: <20090320224416.12284.qmail@sourceware.org> (raw) In-Reply-To: <bug-18190-360@http.gcc.gnu.org/bugzilla/> ------- Comment #13 from rguenth at gcc dot gnu dot org 2009-03-20 22:44 ------- It at least still happens with 4.3 and I have no belief that it is fixed with 4.4 if comment #3 applies. Code generated is also absymal (-O2): _ZN1t18__U3c_clinit__U3e_EJvv: .LFB2: pushl %ebp .LCFI0: movl %esp, %ebp .LCFI1: subl $8, %esp .LCFI2: movl $4, 4(%esp) movl $_Jv_intClass, (%esp) call _Jv_NewPrimArray movl 4(%eax), %edx testl %edx, %edx je .L8 cmpl $1, %edx movl $5, 8(%eax) jbe .L9 cmpl $2, %edx movl $7, 12(%eax) jbe .L10 cmpl $3, %edx movl $9, 16(%eax) jbe .L11 movl $11, 20(%eax) movl %eax, _ZN1t1xE leave ret .L8: movl $0, (%esp) call _Jv_ThrowBadArrayIndex .L9: movl $1, (%esp) call _Jv_ThrowBadArrayIndex .L10: movl $2, (%esp) call _Jv_ThrowBadArrayIndex .L11: movl $3, (%esp) call _Jv_ThrowBadArrayIndex (4.3 again), we do not seem to be able to CSE the load of the array length on the tree level and we have no way (still) of commoning the calls to _Jv_ThrowBadArrayIndex either: <bb 2>: D.241 = _Jv_NewPrimArray (&_Jv_intClass, 4); D.249 = D.241->length; if (D.249 != 0) goto <bb 4>; else goto <bb 3>; <bb 3>: _Jv_ThrowBadArrayIndex (0); <bb 4>: D.241->data[0] = 5; D.263 = D.241->length; if ((unsigned int) D.263 > 1) goto <bb 6>; else goto <bb 5>; <bb 5>: _Jv_ThrowBadArrayIndex (1); <bb 6>: D.241->data[1] = 7; D.277 = D.241->length; if ((unsigned int) D.277 > 2) goto <bb 8>; else goto <bb 7>; <bb 7>: _Jv_ThrowBadArrayIndex (2); <bb 8>: D.241->data[2] = 9; D.291 = D.241->length; if ((unsigned int) D.291 > 3) goto <bb 10>; else goto <bb 9>; <bb 9>: _Jv_ThrowBadArrayIndex (3); <bb 10>: D.241->data[3] = 11; x = D.241; return; -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18190
next prev parent reply other threads:[~2009-03-20 22:44 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-18190-360@http.gcc.gnu.org/bugzilla/> 2005-10-30 22:11 ` [Bug java/18190] [4.0/4.1 " pinskia at gcc dot gnu dot org 2006-02-28 20:36 ` [Bug java/18190] [4.0/4.1/4.2 " mmitchel at gcc dot gnu dot org 2006-05-25 2:42 ` mmitchel at gcc dot gnu dot org 2007-02-14 9:30 ` [Bug java/18190] [4.0/4.1/4.2/4.3 " mmitchel at gcc dot gnu dot org 2008-07-04 16:34 ` [Bug java/18190] [4.2/4.3/4.4 " jsm28 at gcc dot gnu dot org 2009-03-20 18:30 ` steven at gcc dot gnu dot org 2009-03-20 18:30 ` steven at gcc dot gnu dot org 2009-03-20 22:44 ` rguenth at gcc dot gnu dot org [this message] 2009-03-20 22:56 ` steven at gcc dot gnu dot org 2009-03-31 16:20 ` [Bug java/18190] [4.3/4.4/4.5 " jsm28 at gcc dot gnu dot org 2009-08-04 12:26 ` rguenth at gcc dot gnu dot org 2010-05-22 18:10 ` [Bug java/18190] [4.3/4.4/4.5/4.6 " rguenth at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090320224416.12284.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=java-prs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).