public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
From: "Arfrever.FTA at GMail dot Com" <gcc-bugzilla@gcc.gnu.org>
To: java-prs@gcc.gnu.org
Subject: [Bug java/61552] New: Unneeded check for libart
Date: Wed, 18 Jun 2014 17:56:00 -0000	[thread overview]
Message-ID: <bug-61552-8172@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61552

            Bug ID: 61552
           Summary: Unneeded check for libart
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: java
          Assignee: unassigned at gcc dot gnu.org
          Reporter: Arfrever.FTA at GMail dot Com

According to my grepping, libart was actually used only in GCC 3.4.* and 4.0.*
(e.g. libart headers were included in GCC's
libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkImagePainter.c).

libjava/configure.ac in GCC trunk still contains:

      PKG_CHECK_MODULES(LIBART, libart-2.0 >= 2.1)
      AC_SUBST(LIBART_CFLAGS)
      AC_SUBST(LIBART_LIBS)

No Makefile.am file uses LIBART_CFLAGS or LIBART_LIBS.
4 generated Makefile.in files contain useless assignments of LIBART_CFLAGS and
LIBART_LIBS.

$ grep -E "LIBART_(CFLAGS|LIBS)" **/Makefile.am
$ grep -E "LIBART_(CFLAGS|LIBS)" **/Makefile.in
libjava/gcj/Makefile.in:LIBART_CFLAGS = @LIBART_CFLAGS@
libjava/gcj/Makefile.in:LIBART_LIBS = @LIBART_LIBS@
libjava/include/Makefile.in:LIBART_CFLAGS = @LIBART_CFLAGS@
libjava/include/Makefile.in:LIBART_LIBS = @LIBART_LIBS@
libjava/Makefile.in:LIBART_CFLAGS = @LIBART_CFLAGS@
libjava/Makefile.in:LIBART_LIBS = @LIBART_LIBS@
libjava/testsuite/Makefile.in:LIBART_CFLAGS = @LIBART_CFLAGS@
libjava/testsuite/Makefile.in:LIBART_LIBS = @LIBART_LIBS@

I suggest to delete check for libart in 
libjava/configure.ac and regenerate appropriate Makefile.in files.


                 reply	other threads:[~2014-06-18 17:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-61552-8172@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=java-prs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).