public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug java/63355] New: libjava/classpath/native/jni/gstreamer-peer/gst_native_pipeline.c:180: possible typo ?
@ 2014-09-24  7:05 dcb314 at hotmail dot com
  0 siblings, 0 replies; only message in thread
From: dcb314 at hotmail dot com @ 2014-09-24  7:05 UTC (permalink / raw)
  To: java-prs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63355

            Bug ID: 63355
           Summary: libjava/classpath/native/jni/gstreamer-peer/gst_native
                    _pipeline.c:180: possible typo ?
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: java
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com

[trunk/libjava/classpath/native/jni/gstreamer-peer/gst_native_pipeline.c:180]:
(style) Same expression on both sides of '||'.

Source code is

  if (localGstPipelineClass == NULL || localGstPipelineClass == NULL)

I suspect 

  if (localPointerClass == NULL || localGstPipelineClass == NULL)

might have been intended, although it's probably better code
to have the test of localPointerClass immediately after it
is written to, not a few lines later.


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-09-24  7:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-24  7:05 [Bug java/63355] New: libjava/classpath/native/jni/gstreamer-peer/gst_native_pipeline.c:180: possible typo ? dcb314 at hotmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).