From: Mark Wielaard <mark@klomp.org>
To: Andrew Haley <aph@redhat.com>
Cc: classpath-patches <classpath-patches@gnu.org>,
"java@gcc.gnu.org" <java@gcc.gnu.org>
Subject: Re: [cp-patches] [4.8 Regression] gjavah throws an exception
Date: Mon, 17 Dec 2012 18:38:00 -0000 [thread overview]
Message-ID: <1355769481.3850.57.camel@bordewijk.wildebeest.org> (raw)
In-Reply-To: <50CF3C9D.50203@redhat.com>
On Mon, 2012-12-17 at 15:39 +0000, Andrew Haley wrote:
> If a class has inner classes, those inner classes are searched on
> the classpath. This is wrong if the argument to javah is a filename:
> the inner class may not exist on the classpath, and even if they do
> they will be the wrong versions.
>
> IMO, if given filenames gjavah should not search for inner classes
> at all. This patch does so.
> [...]
> 2012-12-17 Andrew Haley <aph@redhat.com>
>
> * tools/gnu/classpath/tools/javah/Main.java (parseClasses): Dont
> scan inner classes if our item is a file.
That looks right to me. As you said on irc, no other javah
implementation seems to support "raw class files" as input. Others only
seem to accept class names. So there is no "best practice" to follow in
this case. Not trying to search for inner classes when a class file is
provided seems a good choice since at the bytecode level there really
isn't such a thing as an inner class (just funnily named classes).
Thanks,
Mark
prev parent reply other threads:[~2012-12-17 18:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 15:39 Andrew Haley
2012-12-17 18:38 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355769481.3850.57.camel@bordewijk.wildebeest.org \
--to=mark@klomp.org \
--cc=aph@redhat.com \
--cc=classpath-patches@gnu.org \
--cc=java@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).