From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: Dave Korn <dave.korn.cygwin@googlemail.com>
Cc: java@gcc.gnu.org, gcc@gcc.gnu.org
Subject: Re: [JAVA,libtool] Big libjava is biiiig.
Date: Wed, 06 May 2009 16:15:00 -0000 [thread overview]
Message-ID: <20090506161419.GA19953@ins.uni-bonn.de> (raw)
In-Reply-To: <4A01B621.7020609@gmail.com>
Hello Dave,
* Dave Korn wrote on Wed, May 06, 2009 at 06:09:05PM CEST:
>
> So I'm currently experimenting with a patch that adds a new option
> "--enable-libgcj-sublibs" in libjava/configure.ac. I may need to add a
> dummy-link-and-relink stage to get the interdependencies working right, or I
> might have to hack something in libtool, but the basic approach of adding a
> bunch of extra libtool declarations based on $(filter)ing the full list of
> dependencies from the complete libgcj_la_LIBADD definition seemed a reasonable
> way to go:
>
> +if BUILD_SUBLIBS
> +libgcj_gnu_la_LIBADD = $(filter gnu/%.lo,$(libgcj_la_LIBADD)) -L$(here)/.libs
> libgcj.la
> +libgcj_java_la_LIBADD = $(filter java/%.lo,$(libgcj_la_LIBADD))
> -L$(here)/.libs libgcj.la
> +libgcj_javax_la_LIBADD = $(filter javax/%.lo,$(libgcj_la_LIBADD))
> -L$(here)/.libs libgcj.la
> +libgcj_misc_la_LIBADD = $(filter-out gnu/%.lo java/%.lo
> javax/%.lo,$(libgcj_la_LIBADD)) -L$(here)/.libs libgcj.la
> +endif
I don't yet see why you would need any kind of libtool hacking.
I also don't see why the GCC tree *ever* uses -L$(something)/.libs in
directories where libtool is used. Just specify in-tree library
dependencies as 'libgcj.la' and automake and libtool will do The Right
Thing. You adding an explicit -L.libs can only lead to installed .la
files retaining paths to build tree locations.
> 1) Would this be a reasonable approach, specifically i) in adding a configure
> option to cause sublibraries to be built, and ii) in using gmake's $(filter)
> construct to crudely subdivide the libraries like this?
You are aware of the fact that it is part of the ABI in which of the
linked DLLs a given symbol was found, and any shuffling of that later
will break that ABI?
You also have to ensure that the sub libraries are self-contained, or at
least their interdependencies form a directed non-cyclic graph (or you
will need very ugly hacks on w32).
> 2) Given that there's a bit of a logjam upstream, and not likely to be
> another libtool release betwen now and the end of stage1,
What makes you think so? There is a backlog of some patches, but that
doesn't mean
- important patches won't go in,
- GCC can't update to a newer unreleased Libtool version; it has done
this several times, and it does not require the GCC developers to
upgrade their build tools.
> would it be
> acceptable (in general) to hack on our in-tree libtool first and send patches
> upstream second (thus still avoiding any potential future merge lossage)?
I don't see a reason for that in your message. Do you have other
reasons for suggesting this?
Cheers,
Ralf
next prev parent reply other threads:[~2009-05-06 16:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4A01B55C.6060700@gmail.com>
2009-05-06 15:58 ` Dave Korn
2009-05-06 16:15 ` Ralf Wildenhues [this message]
2009-05-06 16:27 ` David Daney
2009-05-06 16:31 ` Richard Guenther
2009-05-06 16:40 ` Andrew Haley
2009-08-22 13:24 ` Dave Korn
2009-08-22 16:33 ` Andrew Haley
2009-08-22 18:55 ` Dave Korn
2009-08-28 18:04 ` Tom Tromey
2009-08-28 18:16 ` David Daney
2009-08-28 19:56 ` Dave Korn
2009-05-06 16:57 ` Dave Korn
2009-05-07 21:49 ` Ralf Wildenhues
2009-05-11 17:14 ` Dave Korn
2009-05-11 17:26 ` Andrew Haley
2009-05-11 18:03 ` Dave Korn
2009-05-13 12:38 ` Dave Korn
2009-05-13 16:18 ` Andrew Haley
2009-05-13 17:59 ` Dave Korn
2009-05-13 15:39 ` Dave Korn
2009-05-06 16:39 ` Andrew Haley
2009-05-06 16:45 ` Dave Korn
2009-05-06 17:12 ` Andrew Haley
2009-05-11 17:33 ` Dave Korn
2009-05-11 17:39 ` Andrew Haley
[not found] ` <7230133d0905060959h5371a608nff03cce1e1e98f47@mail.gmail.com>
2009-05-06 17:08 ` Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090506161419.GA19953@ins.uni-bonn.de \
--to=ralf.wildenhues@gmx.de \
--cc=dave.korn.cygwin@googlemail.com \
--cc=gcc@gcc.gnu.org \
--cc=java@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).