public inbox for java@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Botcazou <ebotcazou@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Richard Guenther <rguenther@suse.de>,
	 Diego Novillo <dnovillo@google.com>,
	 fortran@gcc.gnu.org,  java@gcc.gnu.org
Subject: Re: [PATCH] gimplify-unit-at-a-time (final)
Date: Fri, 10 Jul 2009 10:39:00 -0000	[thread overview]
Message-ID: <200907101242.51197.ebotcazou@adacore.com> (raw)
In-Reply-To: <alpine.LNX.2.00.0907071728310.16347@zhemvz.fhfr.qr>

> 	ada/
> 	* utils.c (end_subprog_body): Revert to pre-tuples state.
> 	(gnat_gimplify_function): Do not gimplify here.
> 	(gnat_write_global_declarations): Also finalize the CU.
> 	* misc.c (gnat_parse_file): Do not finalize the CU here.
> 	* trans.c (gigi): Revert to pre-tuples state.

The unused argument of end_subprog_body should be removed as well as

! 	  /*cgraph_remove_node (cgraph_node (info->elab_proc));*/

and

! 	  /* Process the function as others, but for indicating this is an
! 	     elab proc, to be discarded if empty, then propagate the status
! 	     up to the GNAT tree node.  */


It looks like gnat_gimplify_function is now useless; would it possible to get 
rid of it and add

  dump_function (TDI_original, fndecl);

to end_subprog_body right after the call to gnat_genericize?

Otherwise looks OK.

-- 
Eric Botcazou

  parent reply	other threads:[~2009-07-10 10:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-07 15:30 Richard Guenther
2009-07-07 16:23 ` Tobias Burnus
2009-07-10 10:39 ` Eric Botcazou [this message]
2009-07-13  7:59   ` Richard Guenther
2009-07-13  8:45     ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907101242.51197.ebotcazou@adacore.com \
    --to=ebotcazou@adacore.com \
    --cc=dnovillo@google.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).