From: Alan Modra <amodra@bigpond.net.au>
To: Matthias Klose <doko@ubuntu.com>
Cc: Nick Clifton <nickc@redhat.com>,
Martin Thuresson <martin@mtme.org>,
binutils <binutils@sourceware.org>,
Tristan Gingold <gingold@adacore.com>,
GCC Java <java@gcc.gnu.org>
Subject: Re: [regressions in GCC/libjava testsuite] Re: Patch to make bfd compile with -Wc++-compat
Date: Wed, 30 Sep 2009 23:48:00 -0000 [thread overview]
Message-ID: <20090930234835.GC18973@bubble.grove.modra.org> (raw)
In-Reply-To: <4AC3E875.1010007@ubuntu.com>
On Thu, Oct 01, 2009 at 01:23:33AM +0200, Matthias Klose wrote:
> It's the one applied to the binutils subdirectory.
It is probably the addr2line.c change. Try this:
Index: binutils/addr2line.c
===================================================================
RCS file: /cvs/src/src/binutils/addr2line.c,v
retrieving revision 1.34
diff -u -p -r1.34 addr2line.c
--- binutils/addr2line.c 10 Sep 2009 13:40:44 -0000 1.34
+++ binutils/addr2line.c 30 Sep 2009 23:47:53 -0000
@@ -107,9 +107,9 @@ slurp_symtab (bfd *abfd)
if ((bfd_get_file_flags (abfd) & HAS_SYMS) == 0)
return;
- symcount = bfd_read_minisymbols (abfd, FALSE, &minisyms, &size);
+ symcount = bfd_read_minisymbols (abfd, FALSE, minisyms, &size);
if (symcount == 0)
- symcount = bfd_read_minisymbols (abfd, TRUE /* dynamic */, &minisyms, &size);
+ symcount = bfd_read_minisymbols (abfd, TRUE /* dynamic */, minisyms, &size);
if (symcount < 0)
bfd_fatal (bfd_get_filename (abfd));
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2009-09-30 23:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <624836f10909071812q358c0ff8p34ce468ccadb50@mail.gmail.com>
[not found] ` <m3pra1w0t9.fsf@google.com>
[not found] ` <624836f10909082138h1e14eb14j76d08ba0e4d76d0a@mail.gmail.com>
[not found] ` <624836f10909082308p349131c5l103efc029e9e26e0@mail.gmail.com>
[not found] ` <4AA820CB.3030403@redhat.com>
2009-09-30 23:01 ` Matthias Klose
2009-09-30 23:23 ` Matthias Klose
2009-09-30 23:48 ` Alan Modra [this message]
2009-10-01 0:04 ` Alan Modra
2009-10-01 0:20 ` Martin Thuresson
2009-10-01 0:34 ` Dave Korn
2009-10-01 0:46 ` Martin Thuresson
2009-10-01 0:56 ` Ian Lance Taylor
2009-10-01 1:14 ` Matt Rice
2009-10-01 5:37 ` Alan Modra
2009-10-01 11:35 ` Matthias Klose
2009-10-01 1:36 ` Martin Thuresson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930234835.GC18973@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
--cc=doko@ubuntu.com \
--cc=gingold@adacore.com \
--cc=java@gcc.gnu.org \
--cc=martin@mtme.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).