From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21886 invoked by alias); 30 Sep 2009 23:48:48 -0000 Received: (qmail 21864 invoked by uid 22791); 30 Sep 2009 23:48:46 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from nschwmtas06p.mx.bigpond.com (HELO nschwmtas06p.mx.bigpond.com) (61.9.189.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Sep 2009 23:48:41 +0000 Received: from nschwotgx01p.mx.bigpond.com ([121.209.33.16]) by nschwmtas06p.mx.bigpond.com with ESMTP id <20090930234838.BAXD22839.nschwmtas06p.mx.bigpond.com@nschwotgx01p.mx.bigpond.com>; Wed, 30 Sep 2009 23:48:38 +0000 Received: from bubble.grove.modra.org ([121.209.33.16]) by nschwotgx01p.mx.bigpond.com with ESMTP id <20090930234837.WMNF28976.nschwotgx01p.mx.bigpond.com@bubble.grove.modra.org>; Wed, 30 Sep 2009 23:48:37 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 1000) id D71CA170C394; Thu, 1 Oct 2009 09:18:35 +0930 (CST) Date: Wed, 30 Sep 2009 23:48:00 -0000 From: Alan Modra To: Matthias Klose Cc: Nick Clifton , Martin Thuresson , binutils , Tristan Gingold , GCC Java Subject: Re: [regressions in GCC/libjava testsuite] Re: Patch to make bfd compile with -Wc++-compat Message-ID: <20090930234835.GC18973@bubble.grove.modra.org> Mail-Followup-To: Matthias Klose , Nick Clifton , Martin Thuresson , binutils , Tristan Gingold , GCC Java References: <624836f10909071812q358c0ff8p34ce468ccadb50@mail.gmail.com> <624836f10909082138h1e14eb14j76d08ba0e4d76d0a@mail.gmail.com> <624836f10909082308p349131c5l103efc029e9e26e0@mail.gmail.com> <4AA820CB.3030403@redhat.com> <4AC3E34D.3080708@ubuntu.com> <4AC3E875.1010007@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AC3E875.1010007@ubuntu.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-RPD-ScanID: Class unknown; VirusThreatLevel unknown, RefID str=0001.0A150205.4AC3EE56.0061,ss=1,fgs=0 Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org X-SW-Source: 2009-09/txt/msg00054.txt.bz2 On Thu, Oct 01, 2009 at 01:23:33AM +0200, Matthias Klose wrote: > It's the one applied to the binutils subdirectory. It is probably the addr2line.c change. Try this: Index: binutils/addr2line.c =================================================================== RCS file: /cvs/src/src/binutils/addr2line.c,v retrieving revision 1.34 diff -u -p -r1.34 addr2line.c --- binutils/addr2line.c 10 Sep 2009 13:40:44 -0000 1.34 +++ binutils/addr2line.c 30 Sep 2009 23:47:53 -0000 @@ -107,9 +107,9 @@ slurp_symtab (bfd *abfd) if ((bfd_get_file_flags (abfd) & HAS_SYMS) == 0) return; - symcount = bfd_read_minisymbols (abfd, FALSE, &minisyms, &size); + symcount = bfd_read_minisymbols (abfd, FALSE, minisyms, &size); if (symcount == 0) - symcount = bfd_read_minisymbols (abfd, TRUE /* dynamic */, &minisyms, &size); + symcount = bfd_read_minisymbols (abfd, TRUE /* dynamic */, minisyms, &size); if (symcount < 0) bfd_fatal (bfd_get_filename (abfd)); -- Alan Modra Australia Development Lab, IBM