From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29133 invoked by alias); 16 Nov 2009 14:22:33 -0000 Received: (qmail 29082 invoked by uid 22791); 16 Nov 2009 14:22:32 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from bromo.med.uc.edu (HELO bromo.med.uc.edu) (129.137.3.146) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Mon, 16 Nov 2009 14:21:49 +0000 Received: from bromo.med.uc.edu (localhost.localdomain [127.0.0.1]) by bromo.med.uc.edu (Postfix) with ESMTP id E0E06B0060; Mon, 16 Nov 2009 09:21:47 -0500 (EST) Received: (from howarth@localhost) by bromo.med.uc.edu (8.14.3/8.14.3/Submit) id nAGELlZg006563; Mon, 16 Nov 2009 09:21:47 -0500 Date: Mon, 16 Nov 2009 14:22:00 -0000 From: Jack Howarth To: Bryce McKinlay Cc: Eric Botcazou , java@gcc.gnu.org Subject: Re: [patch] Fix oddity in personality routine Message-ID: <20091116142147.GA6512@bromo.med.uc.edu> References: <200911131850.03946.ebotcazou@adacore.com> <20091113191758.GA22781@bromo.med.uc.edu> <7230133d0911151501k19f447a8of7956ebe1cea8813@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <7230133d0911151501k19f447a8of7956ebe1cea8813@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Content-Transfer-Encoding: quoted-printable Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org X-SW-Source: 2009-11/txt/msg00037.txt.bz2 On Sun, Nov 15, 2009 at 11:01:22PM +0000, Bryce McKinlay wrote: > On Fri, Nov 13, 2009@7:17 PM, Jack Howarth wro= te: >=20 > >> Index: exception.cc > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> --- exception.cc =A0 =A0 =A0(revision 154059) > >> +++ exception.cc =A0 =A0 =A0(working copy) > >> @@ -328,7 +328,7 @@ PERSONALITY_FUNCTION (int version, > >> =A0#ifdef HAVE_GETIPINFO > >> =A0 =A0ip =3D _Unwind_GetIPInfo (context, &ip_before_insn); > >> =A0#else > >> - =A0ip =3D _Unwind_GetIP (context) - 1; > >> + =A0ip =3D _Unwind_GetIP (context); > >> =A0#endif > >> =A0 =A0if (! ip_before_insn) > >> =A0 =A0 =A0--ip; > > > > > > Shouldn't this fix also get backported to gcc-4_4-branch and > > gcc-4_3-branch as well? They both have r128098. >=20 > Jack, can you confirm that this actually fixes the problem you are > seeing on Darwin? r128098 dates from 2007 - it's hard to believe that > nobody has had a working GCJ on Darwin since then! >=20 > Bryce Bryce Unfortunately, r154159 didn't eliminate the crashes on x86_64-apple-darw= in9 or x86_64-apple-darwin10 when compiling java code with gcj on either a Core= 2Duo or Xeon. Oddly... http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D41991#c3 fixes the issue for Andreas Tobler. I am wondering if this is really just tending the problem to go latent under certain conditions though. Also, the Makefile.in and Makefile.am still seem a bit odd to me... http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D41991#c10 Using variables before they are actually assigned in Makefiles can't be right. I wonder if the same issues exist elsewhere in the libjava build infrastructure. Jack ps I still ought to test the patch in comment 10 under x86_64-apple-darwin9 (as I only tested with x86_64-apple-darwin10). The darwin10 build has the additional complexity that the FSF libgcc isn't ever really used since Apple has subsumed libgcc into libSystem and favors those symbols over any in libgcc. So the unwinder in libSystem is always used under darwin10 regardless of which libgcc is linked in.