From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1264 invoked by alias); 20 Dec 2009 00:30:39 -0000 Received: (qmail 1251 invoked by uid 22791); 20 Dec 2009 00:30:38 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from bromo.med.uc.edu (HELO bromo.med.uc.edu) (129.137.3.146) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sun, 20 Dec 2009 00:30:33 +0000 Received: from bromo.med.uc.edu (localhost.localdomain [127.0.0.1]) by bromo.med.uc.edu (Postfix) with ESMTP id 844BA400007; Sat, 19 Dec 2009 19:30:31 -0500 (EST) Received: (from howarth@localhost) by bromo.med.uc.edu (8.14.3/8.14.3/Submit) id nBK0UVKQ000552; Sat, 19 Dec 2009 19:30:31 -0500 Date: Sun, 20 Dec 2009 00:30:00 -0000 From: Jack Howarth To: Bryce McKinlay Cc: Andrew Haley , java@gcc.gnu.org Subject: Re: _Unwind_FindEnclosingFunction vs darwin Message-ID: <20091220003031.GA494@bromo.med.uc.edu> References: <20091218144617.GA21353@bromo.med.uc.edu> <4B2B9934.7010205@redhat.com> <20091218204147.GA23604@bromo.med.uc.edu> <4B2CB00D.5070405@redhat.com> <20091219134725.GA29636@bromo.med.uc.edu> <4B2D0CB2.6080705@redhat.com> <20091219184907.GA31305@bromo.med.uc.edu> <7230133d0912191154s18d9c245m9149b5b7f6b0680f@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7230133d0912191154s18d9c245m9149b5b7f6b0680f@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org X-SW-Source: 2009-12/txt/msg00051.txt.bz2 On Sat, Dec 19, 2009 at 07:54:15PM +0000, Bryce McKinlay wrote: > On Sat, Dec 19, 2009 at 6:49 PM, Jack Howarth wrote: > > > to libjava/include/posix.h, what is the correct way to access the missing declarations > > for dwarf_eh_bases, dwarf_fde, fde and _Unwind_Find_FDE? Are we supposed to directly > > include the *dw2* headers from the gcc subdirectory or duplicate their contents in this > > header? > > I think you only really need to copy the dwarf_eh_bases struct and the > definition for _Unwind_Find_FDE itself. The others can be treated as > opaque. > > Please also call it _Jv_Unwind_Find_FDE and use configure.ac to enable > it for Darwin (only) as I described before - its bad to override > functions with #defines... > > Bryce I confused about the details of functions called within a static inline function. Do we have to create additional static inlines for each of those called functions in the same header? If so, we are going to have to add a lot of code from unwind-dw2-fde-darwin.c since _Unwind_Find_FDE() calls _Unwind_Find_registered_FDE(). Perhaps it would be easier if we added a duplicated _Unwind_FindEnclosingFunction() to unwind-dw2-fde-darwin.c as _darwin10_Unwind_FindEnclosingFunction() and emitted that symbol via the versioned libgcc_ext stubs. I know that works in theory and would be a much smaller patch. Jack