From: Andrew Haley <aph@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: GCJ <java@gcc.gnu.org>
Subject: Patch for _Jv_CheckOrCreateLoadingConstraint
Date: Wed, 11 Mar 2009 17:38:00 -0000 [thread overview]
Message-ID: <49B7F6F4.1060106@redhat.com> (raw)
Maven2 doesn't build at the moment because our code to check the loading
constraints (Section 5.3.4, JVM Spec Second Edition) is wrong.
Tom, is this the correct fix?
Andrew.
2009-03-11 Tom Tromey <tromey@redhat.com>
* link.cc (_Jv_Linker::find_field): Pass the field_type to
_Jv_CheckOrCreateLoadingConstraint, not the class that is
requesting the field.
--- link.cc~ 2009-01-14 11:10:39.000000000 +0000
+++ link.cc 2009-03-11 17:33:31.000000000 +0000
@@ -248,7 +248,7 @@ _Jv_Linker::find_field (jclass klass, jc
// Note that the field returned by find_field_helper is always
// resolved. However, we still use the constraint mechanism
// because this may affect other lookups.
- _Jv_CheckOrCreateLoadingConstraint (klass, (*found_class)->loader);
+ _Jv_CheckOrCreateLoadingConstraint (field_type, (*found_class)->loader);
}
else
{
next reply other threads:[~2009-03-11 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 17:38 Andrew Haley [this message]
2009-03-11 18:07 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B7F6F4.1060106@redhat.com \
--to=aph@redhat.com \
--cc=java@gcc.gnu.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).