public inbox for java@gcc.gnu.org
 help / color / mirror / Atom feed
From: Dave Korn <dave.korn.cygwin@googlemail.com>
To: Kai Tietz <Kai.Tietz@onevision.com>
Cc: Andrew Haley <aph@redhat.com>, gcc@gcc.gnu.org, java@gcc.gnu.org
Subject: Re: [patch libjava]: Add missing file for Win32
Date: Fri, 24 Jul 2009 12:02:00 -0000	[thread overview]
Message-ID: <4A69A586.3050302@gmail.com> (raw)
In-Reply-To: <OF02665440.EF8B0A6B-ONC12575FD.0032DF7A-C12575FD.00333BBB@onevision.de>

Kai Tietz wrote:

>         * gnu/java/security/jce/prng/natVMSecureRandomWin32.cc: New Win32
>         specific implementation.

> +      (JvNewStringLatin1 ("Error function not implemented for Win32 target."));

  That's slightly ambiguous; it needs a colon after 'Error', to make clear it
isn't an "error function" that is not implemented!

    cheers,
      DaveK

      parent reply	other threads:[~2009-07-24 12:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24  9:20 Kai Tietz
2009-07-24 11:03 ` Andrew Haley
2009-07-24 11:17   ` Kai Tietz
2009-07-24 11:19     ` Andrew Haley
2009-07-24 11:28       ` Kai Tietz
2009-07-24 12:02 ` Dave Korn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A69A586.3050302@gmail.com \
    --to=dave.korn.cygwin@googlemail.com \
    --cc=Kai.Tietz@onevision.com \
    --cc=aph@redhat.com \
    --cc=gcc@gcc.gnu.org \
    --cc=java@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).