[patch libjava]: Add missing file for Win32

[patch libjava]: Add missing file for Win32

[Kai Tietz]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hello,

This patch adds dummy implementation for 
gnu/java/security/jce/prng/natVMSecureRandomWin32.cc file for Win32 build. 
It throws just an exception for not supporting this method.

ChangeLog

2009-07-24  Kai Tietz  <kai.tietz@onevision.com>

        * gnu/java/security/jce/prng/natVMSecureRandomWin32.cc: New Win32
        specific implementation.

Tested for i686-pc-mingw32. Ok for apply to trunk?


Cheers,
Kai



|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

[-- Attachment #2: w32_java.diff --]
[-- Type: application/octet-stream, Size: 1181 bytes --]

Index: gcc/libjava/gnu/java/security/jce/prng/natVMSecureRandomWin32.cc
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gcc/libjava/gnu/java/security/jce/prng/natVMSecureRandomWin32.cc	2009-07-24 11:15:22.296091500 +0200
@@ -0,0 +1,32 @@
+// natVMSecureRandomWin32.cc - Native part of VMSecureRandom class for Win32.
+
+/* Copyright (C) 2009 Free Software Foundation
+
+   This file is part of libgcj.
+
+This software is copyrighted work licensed under the terms of the
+Libgcj License.  Please consult the file "LIBGCJ_LICENSE" for
+details.  */
+
+#include <config.h>
+
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <string.h>
+#include <errno.h>
+
+#include <gcj/cni.h>
+#include <java/lang/InternalError.h>
+#include <gnu/java/security/jce/prng/VMSecureRandom.h>
+
+jint
+gnu::java::security::jce::prng::VMSecureRandom::natGenerateSeed(jbyteArray byte_array, jint offset, jint length)
+{
+  if (length != 0)
+    throw new ::java::lang::InternalError
+      (JvNewStringLatin1 ("Error function not implemented for Win32 target."));
+  return 0;
+}
+

Re: [patch libjava]: Add missing file for Win32

[Andrew Haley]

On 07/24/2009 11:19 AM, Kai Tietz wrote:

> This patch adds dummy implementation for 
> gnu/java/security/jce/prng/natVMSecureRandomWin32.cc file for Win32 build. 
> It throws just an exception for not supporting this method.

This should be an UnsupportedOperationException.

Andrew.

Re: [patch libjava]: Add missing file for Win32

[Kai Tietz]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Andrew Haley <aph@redhat.com> wrote on 24.07.2009 13:03:28:

> On 07/24/2009 11:19 AM, Kai Tietz wrote:
> 
> > This patch adds dummy implementation for 
> > gnu/java/security/jce/prng/natVMSecureRandomWin32.cc file for Win32 
build. 
> > It throws just an exception for not supporting this method.
> 
> This should be an UnsupportedOperationException.
> 
> Andrew.
> 

Ok, adjusted.

Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

[-- Attachment #2: w32_java.diff --]
[-- Type: application/octet-stream, Size: 1186 bytes --]

Index: gcc/libjava/gnu/java/security/jce/prng/natVMSecureRandomWin32.cc
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ gcc/libjava/gnu/java/security/jce/prng/natVMSecureRandomWin32.cc	2009-07-24 13:14:44.000916000 +0200
@@ -0,0 +1,32 @@
+// natVMSecureRandomWin32.cc - Native part of VMSecureRandom class for Win32.
+
+/* Copyright (C) 2009 Free Software Foundation
+
+   This file is part of libgcj.
+
+This software is copyrighted work licensed under the terms of the
+Libgcj License.  Please consult the file "LIBGCJ_LICENSE" for
+details.  */
+
+#include <config.h>
+
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <string.h>
+#include <errno.h>
+
+#include <gcj/cni.h>
+#include <java/lang/InternalError.h>
+#include <gnu/java/security/jce/prng/VMSecureRandom.h>
+
+jint
+gnu::java::security::jce::prng::VMSecureRandom::natGenerateSeed(jbyteArray byte_array, jint offset, jint length)
+{
+  if (length != 0)
+    throw new UnsupportedOperationException (
+      JvNewStringLatin1 ("natGenerateSeed is not available for Win32 target."));
+  return 0;
+}
+

Re: [patch libjava]: Add missing file for Win32

[Andrew Haley]

On 07/24/2009 01:17 PM, Kai Tietz wrote:
> Andrew Haley <aph@redhat.com> wrote on 24.07.2009 13:03:28:
> 
>> On 07/24/2009 11:19 AM, Kai Tietz wrote:
>>
>>> This patch adds dummy implementation for 
>>> gnu/java/security/jce/prng/natVMSecureRandomWin32.cc file for Win32 
> build. 
>>> It throws just an exception for not supporting this method.
>> This should be an UnsupportedOperationException.
>>
>> Andrew.
>>
> 
> Ok, adjusted.

OK.

Andrew.

Re: [patch libjava]: Add missing file for Win32

[Kai Tietz]

Andrew Haley <aph@redhat.com> wrote on 24.07.2009 13:19:06:

> OK.

Applied at rev. 150048.

Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

Re: [patch libjava]: Add missing file for Win32

[Dave Korn]

Kai Tietz wrote:

>         * gnu/java/security/jce/prng/natVMSecureRandomWin32.cc: New Win32
>         specific implementation.

> +      (JvNewStringLatin1 ("Error function not implemented for Win32 target."));

  That's slightly ambiguous; it needs a colon after 'Error', to make clear it
isn't an "error function" that is not implemented!

    cheers,
      DaveK