public inbox for java@gcc.gnu.org
 help / color / mirror / Atom feed
From: Erik Larsson <catacombae@gmail.com>
To: java@gcc.gnu.org
Subject: ByteBuffer.asReadOnlyBuffer() and direct byte buffers
Date: Mon, 28 Sep 2009 02:34:00 -0000	[thread overview]
Message-ID: <4AC0208F.2040109@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

Hi group,

In the process of trying to run my JNI-enabled library in gcj/gij I 
discovered what seems to be a bug in libgcj's direct ByteBuffer 
implementation.

When calling ByteBuffer.asReadOnlyBuffer() for a direct byte buffer, gij 
throws at me:
------
Exception in thread "main" java.nio.InvalidMarkException
    at java.nio.Buffer.reset(libgcj.so.10)
    at java.nio.DirectByteBufferImpl.duplicate(libgcj.so.10)
    at java.nio.DirectByteBufferImpl.asReadOnlyBuffer(libgcj.so.10)
    at Test.main(Test.java:18)
------

Test code is attached. The InvalidMarkException goes away if you call 
ByteBuffer.mark() before calling .asReadOnlyBuffer(), but 
.asReadOnlyBuffer() shouldn't require a defined mark (it doesn't for 
regular buffers).

gij version:
------
gij (GNU libgcj) version 4.4.1

Copyright (C) 2007 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
------

OS: Ubuntu 9.10 (prerelease), i386

I did a little research, and it seems this bug was reported against 
Classpath in 2005, along with a fix:
      http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22934

The GNU Classpath code contains what seems to be a fix in the current 
revision of DirectByteBufferImpl (duplicate() method):
     
http://cvs.savannah.gnu.org/viewvc/classpath/java/nio/DirectByteBufferImpl.java?revision=1.24&root=classpath&view=markup

...but gcc's libjava doesn't have that particular line ('if (this.mark 
!= -1)'):
     
http://gcc.gnu.org/viewcvs/trunk/libjava/java/nio/DirectByteBufferImpl.java?revision=141271&view=markup

Regards,

- Erik

[-- Attachment #2: Test.java --]
[-- Type: text/plain, Size: 379 bytes --]

import java.nio.ByteBuffer;

public class Test {
    public static void main(String[] args) {
	ByteBuffer bb = ByteBuffer.allocateDirect(1024);
	System.err.println("Created readwrite direct buffer: " + bb);
	//bb.mark(); // Uncomment this line to prevent exception.
	ByteBuffer bbro = bb.asReadOnlyBuffer();
	System.err.println("Created readonly direct buffer: " + bbro);
    }
}

             reply	other threads:[~2009-09-28  2:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-28  2:34 Erik Larsson [this message]
2009-10-03  4:30 ` Erik Larsson
2009-10-03  6:19   ` Michael Koch
2009-10-03  8:17     ` Andrew Haley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC0208F.2040109@gmail.com \
    --to=catacombae@gmail.com \
    --cc=java@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).