public inbox for java@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Haley <aph@redhat.com>
To: Matthias Klose <doko@ubuntu.com>
Cc: Ian Lance Taylor <iant@google.com>,
	gcc Development <gcc@gcc.gnu.org>,
	        GCC Java <java@gcc.gnu.org>
Subject: Re: --enable-plugin option overloaded
Date: Thu, 22 Oct 2009 09:06:00 -0000	[thread overview]
Message-ID: <4AE02070.2020300@redhat.com> (raw)
In-Reply-To: <4AE006AA.5040503@ubuntu.com>

Matthias Klose wrote:
> On 19.10.2009 19:42, Andrew Haley wrote:
>> Ian Lance Taylor wrote:
>>> Andrew Haley<aph@redhat.com>  writes:
>>>
>>>> Matthias Klose wrote:
>>>>> --enable-plugin is used by classpath (part of libjava) and now by GCC
>>>>> itself. disabling the build of the gcjwebplugin now disables plugin
>>>>> support in GCC as well. Please could the option for enabling GCC
>>>>> plugin
>>>>> support be renamed to something like --enable-plugins,
>>>>> --enable-gcc-plugin, --enable-gcc-plugins ? The only reason for not
>>>>> renaming the existing libjava option is that it was there first, and
>>>>> that it is part of an imported tree.
>>>> That doesn't seem like a good enough reason to me.  We should rename
>>>> the libjava option --enable-web-plugin or --enable-browser-plugin .
>>>
>>> We could rename in the top leve configure/Makefile if we don't want to
>>> touch the classpath sources.
>>
>> That sounds like a nice solution.
> 
> it's not necessary to do this at toplevel, changing libjava is ok.
> tested with --enable-plugin --disable-browser-plugin, and
> --disable-plugin and --enable-browser-plugin.
> 
> Ok for the trunk?

Looks like a good solution.

Andrew.

      reply	other threads:[~2009-10-22  9:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-18 22:08 Matthias Klose
2009-10-19  8:43 ` Andrew Haley
2009-10-19 17:37   ` Ian Lance Taylor
2009-10-19 17:43     ` Andrew Haley
2009-10-22  7:16       ` Matthias Klose
2009-10-22  9:06         ` Andrew Haley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE02070.2020300@redhat.com \
    --to=aph@redhat.com \
    --cc=doko@ubuntu.com \
    --cc=gcc@gcc.gnu.org \
    --cc=iant@google.com \
    --cc=java@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).