* --enable-plugin option overloaded
@ 2009-10-18 22:08 Matthias Klose
2009-10-19 8:43 ` Andrew Haley
0 siblings, 1 reply; 6+ messages in thread
From: Matthias Klose @ 2009-10-18 22:08 UTC (permalink / raw)
To: gcc Development, GCC Java
--enable-plugin is used by classpath (part of libjava) and now by GCC itself.
disabling the build of the gcjwebplugin now disables plugin support in GCC as
well. Please could the option for enabling GCC plugin support be renamed to
something like --enable-plugins, --enable-gcc-plugin, --enable-gcc-plugins ? The
only reason for not renaming the existing libjava option is that it was there
first, and that it is part of an imported tree.
Matthias
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: --enable-plugin option overloaded
2009-10-18 22:08 --enable-plugin option overloaded Matthias Klose
@ 2009-10-19 8:43 ` Andrew Haley
2009-10-19 17:37 ` Ian Lance Taylor
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Haley @ 2009-10-19 8:43 UTC (permalink / raw)
To: Matthias Klose; +Cc: gcc Development, GCC Java
Matthias Klose wrote:
> --enable-plugin is used by classpath (part of libjava) and now by GCC
> itself. disabling the build of the gcjwebplugin now disables plugin
> support in GCC as well. Please could the option for enabling GCC plugin
> support be renamed to something like --enable-plugins,
> --enable-gcc-plugin, --enable-gcc-plugins ? The only reason for not
> renaming the existing libjava option is that it was there first, and
> that it is part of an imported tree.
That doesn't seem like a good enough reason to me. We should rename
the libjava option --enable-web-plugin or --enable-browser-plugin .
Andrew.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: --enable-plugin option overloaded
2009-10-19 8:43 ` Andrew Haley
@ 2009-10-19 17:37 ` Ian Lance Taylor
2009-10-19 17:43 ` Andrew Haley
0 siblings, 1 reply; 6+ messages in thread
From: Ian Lance Taylor @ 2009-10-19 17:37 UTC (permalink / raw)
To: Andrew Haley; +Cc: Matthias Klose, gcc Development, GCC Java
Andrew Haley <aph@redhat.com> writes:
> Matthias Klose wrote:
>> --enable-plugin is used by classpath (part of libjava) and now by GCC
>> itself. disabling the build of the gcjwebplugin now disables plugin
>> support in GCC as well. Please could the option for enabling GCC plugin
>> support be renamed to something like --enable-plugins,
>> --enable-gcc-plugin, --enable-gcc-plugins ? The only reason for not
>> renaming the existing libjava option is that it was there first, and
>> that it is part of an imported tree.
>
> That doesn't seem like a good enough reason to me. We should rename
> the libjava option --enable-web-plugin or --enable-browser-plugin .
We could rename in the top leve configure/Makefile if we don't want to
touch the classpath sources.
Ian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: --enable-plugin option overloaded
2009-10-19 17:37 ` Ian Lance Taylor
@ 2009-10-19 17:43 ` Andrew Haley
2009-10-22 7:16 ` Matthias Klose
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Haley @ 2009-10-19 17:43 UTC (permalink / raw)
To: Ian Lance Taylor; +Cc: Matthias Klose, gcc Development, GCC Java
Ian Lance Taylor wrote:
> Andrew Haley <aph@redhat.com> writes:
>
>> Matthias Klose wrote:
>>> --enable-plugin is used by classpath (part of libjava) and now by GCC
>>> itself. disabling the build of the gcjwebplugin now disables plugin
>>> support in GCC as well. Please could the option for enabling GCC plugin
>>> support be renamed to something like --enable-plugins,
>>> --enable-gcc-plugin, --enable-gcc-plugins ? The only reason for not
>>> renaming the existing libjava option is that it was there first, and
>>> that it is part of an imported tree.
>> That doesn't seem like a good enough reason to me. We should rename
>> the libjava option --enable-web-plugin or --enable-browser-plugin .
>
> We could rename in the top leve configure/Makefile if we don't want to
> touch the classpath sources.
That sounds like a nice solution.
Andrew.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: --enable-plugin option overloaded
2009-10-19 17:43 ` Andrew Haley
@ 2009-10-22 7:16 ` Matthias Klose
2009-10-22 9:06 ` Andrew Haley
0 siblings, 1 reply; 6+ messages in thread
From: Matthias Klose @ 2009-10-22 7:16 UTC (permalink / raw)
To: Andrew Haley; +Cc: Ian Lance Taylor, gcc Development, GCC Java
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
On 19.10.2009 19:42, Andrew Haley wrote:
> Ian Lance Taylor wrote:
>> Andrew Haley<aph@redhat.com> writes:
>>
>>> Matthias Klose wrote:
>>>> --enable-plugin is used by classpath (part of libjava) and now by GCC
>>>> itself. disabling the build of the gcjwebplugin now disables plugin
>>>> support in GCC as well. Please could the option for enabling GCC plugin
>>>> support be renamed to something like --enable-plugins,
>>>> --enable-gcc-plugin, --enable-gcc-plugins ? The only reason for not
>>>> renaming the existing libjava option is that it was there first, and
>>>> that it is part of an imported tree.
>>> That doesn't seem like a good enough reason to me. We should rename
>>> the libjava option --enable-web-plugin or --enable-browser-plugin .
>>
>> We could rename in the top leve configure/Makefile if we don't want to
>> touch the classpath sources.
>
> That sounds like a nice solution.
it's not necessary to do this at toplevel, changing libjava is ok. tested with
--enable-plugin --disable-browser-plugin, and --disable-plugin and
--enable-browser-plugin.
Ok for the trunk?
Matthias
[-- Attachment #2: plugin.diff --]
[-- Type: text/plain, Size: 2114 bytes --]
gcc/
2009-10-22 Matthias Klose <doko@ubuntu.com>
* doc/install.texi: Document --enable-browser-plugin.
libjava/
2009-10-22 Matthias Klose <doko@ubuntu.com>
* configure.ac: Rename --enable-plugin to --enable-browser-plugin,
pass --{en,dis}able-plugin to the classpath configure.
* configure: Regenerate.
Index: gcc/doc/install.texi
===================================================================
--- gcc/doc/install.texi (revision 153445)
+++ gcc/doc/install.texi (working copy)
@@ -1882,6 +1884,9 @@
@item --enable-aot-compile-rpm
Adds aot-compile-rpm to the list of installed scripts.
+@item --enable-browser-plugin
+Build the gcjwebplugin web browser plugin.
+
@table @code
@item ansi
Use the single-byte @code{char} and the Win32 A functions natively,
Index: libjava/configure.ac
===================================================================
--- libjava/configure.ac (revision 153445)
+++ libjava/configure.ac (working copy)
@@ -55,15 +55,15 @@
[version_specific_libs=no]
)
-AC_ARG_ENABLE(plugin,
- AS_HELP_STRING([--enable-plugin],
+AC_ARG_ENABLE(browser-plugin,
+ AS_HELP_STRING([--enable-browser-plugin],
[build gcjwebplugin web browser plugin]),
[case "$enableval" in
- yes) plugin_enabled=yes ;;
- no) plugin_enabled=no ;;
- *) AC_MSG_ERROR([Unknown argument to enable/disable plugin]);;
+ yes) browser_plugin_enabled=yes ;;
+ no) browser_plugin_enabled=no ;;
+ *) AC_MSG_ERROR([Unknown argument to enable/disable browser plugin]);;
esac],
- [plugin_enabled=no]
+ [browser_plugin_enabled=no]
)
AC_ARG_ENABLE(gconf-peer,
@@ -491,8 +491,10 @@
dnl FIXME?
ac_configure_args="$ac_configure_args --disable-examples"
ac_configure_args="$ac_configure_args --with-glibj=build"
-if test "$plugin_enabled" != yes; then
+if test "$browser_plugin_enabled" != yes; then
ac_configure_args="$ac_configure_args --disable-plugin"
+else
+ ac_configure_args="$ac_configure_args --enable-plugin"
fi
if test "$gconf_enabled" != yes; then
ac_configure_args="$ac_configure_args --disable-gconf-peer"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: --enable-plugin option overloaded
2009-10-22 7:16 ` Matthias Klose
@ 2009-10-22 9:06 ` Andrew Haley
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Haley @ 2009-10-22 9:06 UTC (permalink / raw)
To: Matthias Klose; +Cc: Ian Lance Taylor, gcc Development, GCC Java
Matthias Klose wrote:
> On 19.10.2009 19:42, Andrew Haley wrote:
>> Ian Lance Taylor wrote:
>>> Andrew Haley<aph@redhat.com> writes:
>>>
>>>> Matthias Klose wrote:
>>>>> --enable-plugin is used by classpath (part of libjava) and now by GCC
>>>>> itself. disabling the build of the gcjwebplugin now disables plugin
>>>>> support in GCC as well. Please could the option for enabling GCC
>>>>> plugin
>>>>> support be renamed to something like --enable-plugins,
>>>>> --enable-gcc-plugin, --enable-gcc-plugins ? The only reason for not
>>>>> renaming the existing libjava option is that it was there first, and
>>>>> that it is part of an imported tree.
>>>> That doesn't seem like a good enough reason to me. We should rename
>>>> the libjava option --enable-web-plugin or --enable-browser-plugin .
>>>
>>> We could rename in the top leve configure/Makefile if we don't want to
>>> touch the classpath sources.
>>
>> That sounds like a nice solution.
>
> it's not necessary to do this at toplevel, changing libjava is ok.
> tested with --enable-plugin --disable-browser-plugin, and
> --disable-plugin and --enable-browser-plugin.
>
> Ok for the trunk?
Looks like a good solution.
Andrew.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-10-22 9:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-18 22:08 --enable-plugin option overloaded Matthias Klose
2009-10-19 8:43 ` Andrew Haley
2009-10-19 17:37 ` Ian Lance Taylor
2009-10-19 17:43 ` Andrew Haley
2009-10-22 7:16 ` Matthias Klose
2009-10-22 9:06 ` Andrew Haley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).