From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-return-26517-listarch-java=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 496 invoked by alias); 1 Dec 2009 20:15:40 -0000
Received: (qmail 478 invoked by uid 22791); 1 Dec 2009 20:15:40 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-ew0-f214.google.com (HELO mail-ew0-f214.google.com) (209.85.219.214)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Dec 2009 20:15:34 +0000
Received: by ewy6 with SMTP id 6so276487ewy.29         for <multiple recipients>; Tue, 01 Dec 2009 12:15:31 -0800 (PST)
Received: by 10.213.43.130 with SMTP id w2mr3520434ebe.89.1259698531632;         Tue, 01 Dec 2009 12:15:31 -0800 (PST)
Received: from ?192.168.2.99? (cpc2-cmbg8-0-0-cust61.cmbg.cable.ntl.com [82.6.108.62])         by mx.google.com with ESMTPS id 5sm1208256eyh.40.2009.12.01.12.15.29         (version=SSLv3 cipher=RC4-MD5);         Tue, 01 Dec 2009 12:15:30 -0800 (PST)
Message-ID: <4B157D1F.4060901@gmail.com>
Date: Tue, 01 Dec 2009 20:15:00 -0000
From: Dave Korn <dave.korn.cygwin@googlemail.com>
User-Agent: Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version: 1.0
To: tromey@redhat.com
CC: Dave Korn <dave.korn.cygwin@googlemail.com>,   Ben Elliston <bje@au1.ibm.com>,  java <java@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>,   Andrew Haley <aph@redhat.com>
Subject: Re: PATCH, libjava: silence more warnings
References: <1259691731.6215.6.camel@bapbop> <4B1564E4.6060009@gmail.com> <m3d42yo4xf.fsf@fleche.redhat.com>
In-Reply-To: <m3d42yo4xf.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java.gcc.gnu.org>
List-Id: <java.gcc.gnu.org>
List-Subscribe: <mailto:java-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java/>
List-Post: <mailto:java@gcc.gnu.org>
List-Help: <mailto:java-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-owner@gcc.gnu.org
X-SW-Source: 2009-12/txt/msg00008.txt.bz2

Tom Tromey wrote:
>>>>>> "Dave" == Dave Korn <dave.korn.cygwin@googlemail.com> writes:
> 
> Dave> Ben Elliston wrote:
>>> ::java::lang::String *
>>> -java::net::VMURLConnection::guessContentTypeFromBuffer (jbyteArray bytes,
>>> -                                                       jint valid)
>>> +java::net::VMURLConnection::guessContentTypeFromBuffer (jbyteArray bytes __attribute__ ((unused)),
>>> +                                                       jint valid __attribute__ ((unused)))
> 
> Dave>   There's a #define MAYBE_UNUSED in include/jvm.h, as used in
> Dave> java/lang/natClass.cc.  But maybe jvm.h isn't available here?
> 
> It is ok to include jvm.h from any of the CNI code.
> 
> But, it is also ok to just use an unadorned __attribute__.  We know this
> code can only be compiled by g++.

  ... given which, it's hardly worth adding a new header dependency just to
get the macro.  Right, thanks for clarifying that.

    cheers,
      DaveK