From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29485 invoked by alias); 13 Oct 2010 14:14:26 -0000 Received: (qmail 29465 invoked by uid 22791); 13 Oct 2010 14:14:25 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Oct 2010 14:14:15 +0000 Received: (qmail 25672 invoked from network); 13 Oct 2010 14:14:13 -0000 Received: from unknown (HELO ?192.168.0.105?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Oct 2010 14:14:13 -0000 Message-ID: <4CB5BEB9.9000501@codesourcery.com> Date: Wed, 13 Oct 2010 14:14:00 -0000 From: Mark Mitchell User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: Richard Henderson CC: GCC Patches , rguenther@suse.de, joseph@codesourcery.com, jason@redhat.com, java@gcc.gnu.org, ian@airs.com, ebotcazou@libertysurf.fr Subject: Re: [RFC] Centralize knowledge of eh personality routines References: <4CB4E841.1090308@redhat.com> In-Reply-To: <4CB4E841.1090308@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org X-SW-Source: 2010-10/txt/msg00018.txt.bz2 On 10/12/2010 3:59 PM, Richard Henderson wrote: > The driver for this patch is SEH, which will add yet another function > name variant in each of these places in each front end. While I could > adjust each language appropriately, it seems to me that it is a bit > cleaner to centralize this knowledge. > Comments? Objections? None in principle, but I think it would be better to have build_personality_function take a language prefix string (e.g., "gxx" or "gcj") rather than an enum. Logically, the middle-end shouldn't be aware of what front-end languages exist, and passing in a string would avoid that. And also avoid the tree.h -> dwarf2.h issue. -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713