From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-return-26966-listarch-java=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 8284 invoked by alias); 29 Sep 2011 09:34:50 -0000
Received: (qmail 8243 invoked by uid 22791); 29 Sep 2011 09:34:49 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_GC,TW_IB
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Sep 2011 09:34:34 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8T9YY0L012405	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <java@gcc.gnu.org>; Thu, 29 Sep 2011 05:34:34 -0400
Received: from zebedee.pink (ovpn-113-55.phx2.redhat.com [10.3.113.55])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p8T9YWrK025842;	Thu, 29 Sep 2011 05:34:33 -0400
Message-ID: <4E843BA8.50409@redhat.com>
Date: Thu, 29 Sep 2011 09:34:00 -0000
From: Andrew Haley <aph@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.22) Gecko/20110906 Fedora/3.1.14-1.fc14 Thunderbird/3.1.14
MIME-Version: 1.0
To: java@gcc.gnu.org
Subject: Re: libjava build failure with read-only source tree
References: <4E8445DE0200007800058686@nat28.tlf.novell.com> <CALUNu-rTAeDOy+v+FcTMgvzdCDGvhP3Wg2_vF6KA3cEYwYsVog@mail.gmail.com>
In-Reply-To: <CALUNu-rTAeDOy+v+FcTMgvzdCDGvhP3Wg2_vF6KA3cEYwYsVog@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java.gcc.gnu.org>
List-Id: <java.gcc.gnu.org>
List-Subscribe: <mailto:java-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java/>
List-Post: <mailto:java@gcc.gnu.org>
List-Help: <mailto:java-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-owner@gcc.gnu.org
X-SW-Source: 2011-09/txt/msg00023.txt.bz2

On 09/29/2011 10:31 AM, Bryce McKinlay wrote:
> On Thu, Sep 29, 2011 at 9:18 AM, Jan Beulich <JBeulich@suse.com> wrote:
> 
>> --- a/libjava/classpath/tools/Makefile.am
>> +++ b/libjava/classpath/tools/Makefile.am
>> @@ -371,6 +371,7 @@ endif
>>  ## BEGIN GCJ LOCAL
>>        cp -pR $(srcdir)/asm .
>>        cp -pR $(srcdir)/classes .
>> +       find asm classes -type d -exec chmod u+w \{\} \;
>>        if [ -d asm/.svn ]; then \
>>          find asm classes -depth -type d -name .svn -exec rm -rf \{\} \;; \
>>        fi
> 
> This patch looks fine to me, though I wonder if there is any good
> reason why "cp -p" was used in the first place?
> 
> In any case, I'd say you can go ahead and check this in under the
> "obvious" rule.

Maybe, but I'm not sure why the files are being copied in the source
tree anyway.  Unless gcj-maintainer-mode is enabled, it shouldn't
be necessary.

Andrew.