From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-return-26967-listarch-java=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 32418 invoked by alias); 29 Sep 2011 09:48:15 -0000
Received: (qmail 32409 invoked by uid 22791); 29 Sep 2011 09:48:14 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,TW_IB
X-Spam-Check-By: sourceware.org
Received: from nat28.tlf.novell.com (HELO nat28.tlf.novell.com) (130.57.49.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Sep 2011 09:48:00 +0000
Received: from EMEA1-MTA by nat28.tlf.novell.com	with Novell_GroupWise; Thu, 29 Sep 2011 10:47:59 +0100
Message-Id: <4E845AED020000780005870B@nat28.tlf.novell.com>
Date: Thu, 29 Sep 2011 09:48:00 -0000
From: "Jan Beulich" <JBeulich@suse.com>
To: "Bryce McKinlay" <bmckinlay@gmail.com>
Cc: <java@gcc.gnu.org>
Subject: Re: libjava build failure with read-only source tree
References: <4E8445DE0200007800058686@nat28.tlf.novell.com> <CALUNu-rTAeDOy+v+FcTMgvzdCDGvhP3Wg2_vF6KA3cEYwYsVog@mail.gmail.com>
In-Reply-To: <CALUNu-rTAeDOy+v+FcTMgvzdCDGvhP3Wg2_vF6KA3cEYwYsVog@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java.gcc.gnu.org>
List-Id: <java.gcc.gnu.org>
List-Subscribe: <mailto:java-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java/>
List-Post: <mailto:java@gcc.gnu.org>
List-Help: <mailto:java-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-owner@gcc.gnu.org
X-SW-Source: 2011-09/txt/msg00024.txt.bz2

>>> On 29.09.11 at 11:31, Bryce McKinlay <bmckinlay@gmail.com> wrote:
> On Thu, Sep 29, 2011 at 9:18 AM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
>> --- a/libjava/classpath/tools/Makefile.am
>> +++ b/libjava/classpath/tools/Makefile.am
>> @@ -371,6 +371,7 @@ endif
>>  ## BEGIN GCJ LOCAL
>>        cp -pR $(srcdir)/asm .
>>        cp -pR $(srcdir)/classes .
>> +       find asm classes -type d -exec chmod u+w \{\} \;
>>        if [ -d asm/.svn ]; then \
>>          find asm classes -depth -type d -name .svn -exec rm -rf \{\} \;=
; \
>>        fi
>=20
> This patch looks fine to me, though I wonder if there is any good
> reason why "cp -p" was used in the first place?

Perhaps to retain the timestamps of the files without becoming too
system specific (i.e. dependent on cp's support of
--preserve=3Dtimestamps)?

> In any case, I'd say you can go ahead and check this in under the
> "obvious" rule.

Yeah, probably.

Thanks, Jan