From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-return-27166-listarch-java=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 17666 invoked by alias); 4 Sep 2012 16:22:48 -0000
Received: (qmail 17641 invoked by uid 22791); 4 Sep 2012 16:22:45 -0000
X-SWARE-Spam-Status: No, hits=-7.3 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_GC
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Sep 2012 16:22:30 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q84GMUof013089	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 4 Sep 2012 12:22:30 -0400
Received: from zebedee.pink (ovpn-113-128.phx2.redhat.com [10.3.113.128])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q84GMSmR007939;	Tue, 4 Sep 2012 12:22:28 -0400
Message-ID: <50462AC3.3000900@redhat.com>
Date: Tue, 04 Sep 2012 16:22:00 -0000
From: Andrew Haley <aph@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0
MIME-Version: 1.0
To: Dehao Chen <dehao@google.com>
CC: Richard Henderson <rth@redhat.com>, Jason Merrill <jason@redhat.com>,        Richard Guenther <richard.guenther@gmail.com>, gcc-patches@gcc.gnu.org,        David Li <davidxl@google.com>, java@gcc.gnu.org
Subject: Re: [PATCH] Set correct source location for deallocator calls
References: <CAO2gOZXfnETUe4wqjT7p6fd61hXreu9PDfqKxNz+HxpE0E7K0g@mail.gmail.com>	<50228C38.5080703@redhat.com>	<CAO2gOZUbkTsnJ2fwgeNhcRmxkzzJEifECeiF=_YRUjeKDeRMdA@mail.gmail.com>	<502294A1.3060800@redhat.com>	<50243480.7090803@redhat.com>	<CAO2gOZURCuWUk2MVwCwmwrijNzWxJt3q=HUpU7=Qv6zB9e-uqA@mail.gmail.com>	<50254A50.8070208@redhat.com>	<CAO2gOZXhHuFGJ0z=jvkYKZ84EoDaPSYVjxS7QzGore56SyhWyQ@mail.gmail.com>	<50255B35.9020705@redhat.com>	<CAO2gOZWe+qMrVyvOoo7Ek-di0NKZxxU4Z=pqrDCqqCCAfctZOw@mail.gmail.com>	<50258712.4070002@redhat.com>	<CAO2gOZUQQjmKtooyXXAfgFoNVbeNwtT+P=E7pQ6jC=e07Nsr2g@mail.gmail.com>	<CAO2gOZX-Gn+b6LEzps5zxhgmwQWcJ-zFqG=a7hesW6fbVyxZYQ@mail.gmail.com>	<502E6774.8050609@redhat.com>	<CAO2gOZWhueDAShNLbNcJpkHA6QqXk1LNZhEMFvfT77aTZTCH9w@mail.gmail.com>	<503F7876.7030606@redhat.com>	<503F84A9.8010504@redhat.com>	<503F95D8.5010506! @redhat.com> <CAO2gOZUxD9-Y3O6iS22HNEHUWaH=0Cm97FZ+KHmhkLmCzahVAA@mail.gmail.com>
In-Reply-To: <CAO2gOZUxD9-Y3O6iS22HNEHUWaH=0Cm97FZ+KHmhkLmCzahVAA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java.gcc.gnu.org>
List-Id: <java.gcc.gnu.org>
List-Subscribe: <mailto:java-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java/>
List-Post: <mailto:java@gcc.gnu.org>
List-Help: <mailto:java-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-owner@gcc.gnu.org
X-SW-Source: 2012-09/txt/msg00001.txt.bz2

On 09/04/2012 05:07 PM, Dehao Chen wrote:
> On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson <rth@redhat.com> wrote:
>> On 08/30/2012 08:20 AM, Andrew Haley wrote:
>>> Is the problem simply that the logic to
>>> scan the assembly code isn't present in the libgcj testsuite?
>>
>> Yes, exactly.
> 
> For this case, I don't think that we want a testcase to rely on
> addr2line in the system. So how about that that we add a test when
> assembly scan is available in libgcj testsuit?

Fine by me.  I guess you can just copy the scanning code from the gcc
testsuite.

Andrew.