From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18243 invoked by alias); 4 Sep 2012 17:12:23 -0000 Received: (qmail 18205 invoked by uid 22791); 4 Sep 2012 17:12:22 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_GC X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Sep 2012 17:12:05 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q84HC4sS018800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 4 Sep 2012 13:12:04 -0400 Received: from zebedee.pink (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q84HC2xV005268; Tue, 4 Sep 2012 13:12:02 -0400 Message-ID: <50463661.1020303@redhat.com> Date: Tue, 04 Sep 2012 17:12:00 -0000 From: Andrew Haley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Bryce McKinlay CC: Dehao Chen , Richard Henderson , Jason Merrill , Richard Guenther , gcc-patches@gcc.gnu.org, David Li , java@gcc.gnu.org Subject: Re: [PATCH] Set correct source location for deallocator calls References: <50243480.7090803@redhat.com> <50254A50.8070208@redhat.com> <50255B35.9020705@redhat.com> <50258712.4070002@redhat.com> <502E6774.8050609@redhat.com> <503F7876.7030606@redhat.com> <503F84A9.8010504@redhat.com> <503F95D8.5010506@redhat.com> <50462ED2.30007@r! edhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org X-SW-Source: 2012-09/txt/msg00005.txt.bz2 On 09/04/2012 06:08 PM, Bryce McKinlay wrote: > On Tue, Sep 4, 2012 at 5:39 PM, Andrew Haley wrote: >> On 09/04/2012 05:32 PM, Bryce McKinlay wrote: >>> On Tue, Sep 4, 2012 at 5:07 PM, Dehao Chen wrote: >>>> On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson wrote: >>>>> On 08/30/2012 08:20 AM, Andrew Haley wrote: >>>>>> Is the problem simply that the logic to >>>>>> scan the assembly code isn't present in the libgcj testsuite? >>>>> >>>>> Yes, exactly. >>>> >>>> For this case, I don't think that we want a testcase to rely on >>>> addr2line in the system. So how about that that we add a test when >>>> assembly scan is available in libgcj testsuit? >>> >>> Once Ian Lance Taylor's libbacktrace patch is integrated (see: >>> http://gcc.gnu.org/ml/gcc/2012-08/msg00317.html), we'll be able to get >>> rid of the code that calls addr2line from libgcj. >> >> As I understand it, Ian Taylor's backtrace patch is intended for use in >> gcc development, and as he puts it "Since its use in GCC would >> be purely for GCC developers, it's not essential that it be fully >> portable." Not for gcj runtime. > > He's also planning to use it for libgo, and other gcc runtime libs > have indicated interest. It doesn't have to work on all platforms, and > I can't see how it would be any less portable than addr2line! I certainly can. Maybe once it's shaken-down so it's at least as robust as what we have now it'll be OK. I suspect it hasn't had much testing with, for example, unwinding through signal handlers. Andrew.