public inbox for java@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Haley <aph@redhat.com>
To: Andrew MacLeod <amacleod@redhat.com>,
	       Richard Biener <richard.guenther@gmail.com>,
	       Richard Henderson <rth@redhat.com>,
	       gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Jeff Law <law@redhat.com>, java@gcc.gnu.org
Subject: Re: [patch] Provide a can_compare_and_swap_p target hook.
Date: Thu, 06 Nov 2014 18:23:00 -0000	[thread overview]
Message-ID: <545BBCA5.7060203@redhat.com> (raw)
In-Reply-To: <545BB682.9000209@redhat.com>

On 11/06/2014 05:57 PM, Andrew MacLeod wrote:
> It looks like java is deciding whether or not GCC can inline atomic 
> operations or not, and if it can't, doesn't want the atomic 
> operations...   which presumably means there is no dependency on 
> libatomic at runtime.
> 
> A call to can_compare_and_swap_p(mode) is analogous to a compile time 
> version of folding atomic_always_lock_free(mode) to a constant...   
> Frankly that seems like a reasonable question for some front end to 
> ask...  and elect not to emit atomic calls if so desired. (which is what 
> java is doing I think)
> 
> whether it still needs to do that is a question for some java person.

I did it because some targets did not have library support for some
builtins, so a compile would fail with a (to a Java programmer)
baffling error message.

The Java operations certainly should use the generic builtins.

Andrew.



  reply	other threads:[~2014-11-06 18:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5458FE9C.2090409@redhat.com>
     [not found] ` <54590C19.40208@redhat.com>
     [not found]   ` <54591348.1010904@redhat.com>
     [not found]     ` <545913A4.5010400@redhat.com>
     [not found]       ` <54591B3A.8030908@redhat.com>
     [not found]         ` <70044BE8-9F38-4BDB-B73F-6E2FC9AC2629@gmail.com>
     [not found]           ` <54593352.2000700@redhat.com>
2014-11-06 17:57             ` Andrew MacLeod
2014-11-06 18:23               ` Andrew Haley [this message]
2014-11-06 19:05                 ` Andrew MacLeod
2014-11-07  9:31                   ` Andrew Haley
2014-11-07 13:31                     ` Andrew MacLeod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545BBCA5.7060203@redhat.com \
    --to=aph@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java@gcc.gnu.org \
    --cc=law@redhat.com \
    --cc=richard.guenther@gmail.com \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).