From: Martin Thuresson <martin@mtme.org>
To: Matthias Klose <doko@ubuntu.com>, Nick Clifton <nickc@redhat.com>,
Martin Thuresson <martin@mtme.org>,
binutils <binutils@sourceware.org>,
Tristan Gingold <gingold@adacore.com>,
GCC Java <java@gcc.gnu.org>
Subject: Re: [regressions in GCC/libjava testsuite] Re: Patch to make bfd compile with -Wc++-compat
Date: Thu, 01 Oct 2009 01:36:00 -0000 [thread overview]
Message-ID: <624836f10909301836i175fc668g602ef310561a442b@mail.gmail.com> (raw)
In-Reply-To: <624836f10909301745k5ffdcc77s1d8d0262093fc38c@mail.gmail.com>
On Wed, Sep 30, 2009 at 5:45 PM, Martin Thuresson <martin@mtme.org> wrote:
> Here is a patch that fixes a bug introduced with my patch. Im sorry
> for the first mistake.
> I was unable to run make check on my mac laptop, but will do it on my
> linux box in 30 min
> or so.
"make check-binutils" passed on target x86_64-linux. My change
was just a mechanical change to avoid C++ warning, so I have
nothing against the bigger issue being fixed.
2009-09-30 Martin Thuresson <martin@mtme.org>
* binutils/addr2line.c (slurp_symtab): Fixed pointer bug.
> On Wed, Sep 30, 2009 at 5:20 PM, Martin Thuresson <martin@mtme.org> wrote:
>> On Wed, Sep 30, 2009 at 5:04 PM, Alan Modra <amodra@bigpond.net.au> wrote:
>>> On Thu, Oct 01, 2009 at 09:18:35AM +0930, Alan Modra wrote:
>>>> On Thu, Oct 01, 2009 at 01:23:33AM +0200, Matthias Klose wrote:
>>>> > It's the one applied to the binutils subdirectory.
>>>>
>>>> It is probably the addr2line.c change. Try this:
>>>
>>> That's not the right patch, but does identify the breakage..
>>> bfd_read_minisymbols ought to take a void * param instead of void **,
>>> I think.
>>
>> The issue in questions seems to be my patch from here:
>> http://sourceware.org/ml/binutils/2009-09/msg00276.html
>>
>> I cant recall why my change stopped the -Wc++-error. Ill take
>> a look and will submit a fix.
>>
>> Martin
>>
>>
>> Excerpt:
>>
>> diff -u -u -p -r1.33 addr2line.c
>> --- binutils/addr2line.c 2 Sep 2009 07:22:31 -0000 1.33
>> +++ binutils/addr2line.c 9 Sep 2009 23:01:26 -0000
>> @@ -102,13 +102,14 @@ slurp_symtab (bfd *abfd)
>> {
>> long symcount;
>> unsigned int size;
>> + void *minisyms = &syms;
>>
>> if ((bfd_get_file_flags (abfd) & HAS_SYMS) == 0)
>> return;
>>
>> - symcount = bfd_read_minisymbols (abfd, FALSE, (void *) &syms, &size);
>> + symcount = bfd_read_minisymbols (abfd, FALSE, &minisyms, &size);
>> if (symcount == 0)
>> - symcount = bfd_read_minisymbols (abfd, TRUE /* dynamic */, (void
>> *) &syms, &size);
>> + symcount = bfd_read_minisymbols (abfd, TRUE /* dynamic */,
>> &minisyms, &size);
>>
>> if (symcount < 0)
>> bfd_fatal (bfd_get_filename (abfd));
>>
>
prev parent reply other threads:[~2009-10-01 1:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <624836f10909071812q358c0ff8p34ce468ccadb50@mail.gmail.com>
[not found] ` <m3pra1w0t9.fsf@google.com>
[not found] ` <624836f10909082138h1e14eb14j76d08ba0e4d76d0a@mail.gmail.com>
[not found] ` <624836f10909082308p349131c5l103efc029e9e26e0@mail.gmail.com>
[not found] ` <4AA820CB.3030403@redhat.com>
2009-09-30 23:01 ` Matthias Klose
2009-09-30 23:23 ` Matthias Klose
2009-09-30 23:48 ` Alan Modra
2009-10-01 0:04 ` Alan Modra
2009-10-01 0:20 ` Martin Thuresson
2009-10-01 0:34 ` Dave Korn
2009-10-01 0:46 ` Martin Thuresson
2009-10-01 0:56 ` Ian Lance Taylor
2009-10-01 1:14 ` Matt Rice
2009-10-01 5:37 ` Alan Modra
2009-10-01 11:35 ` Matthias Klose
2009-10-01 1:36 ` Martin Thuresson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=624836f10909301836i175fc668g602ef310561a442b@mail.gmail.com \
--to=martin@mtme.org \
--cc=binutils@sourceware.org \
--cc=doko@ubuntu.com \
--cc=gingold@adacore.com \
--cc=java@gcc.gnu.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).