From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28801 invoked by alias); 21 May 2009 17:17:48 -0000 Received: (qmail 28791 invoked by uid 22791); 21 May 2009 17:17:47 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from fk-out-0910.google.com (HELO fk-out-0910.google.com) (209.85.128.185) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 May 2009 17:17:42 +0000 Received: by fk-out-0910.google.com with SMTP id 18so567864fks.8 for ; Thu, 21 May 2009 10:17:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.239.149.195 with SMTP id k3mr210529hbb.108.1242926258875; Thu, 21 May 2009 10:17:38 -0700 (PDT) In-Reply-To: <4A15890E.30001@gmail.com> References: <4A15890E.30001@gmail.com> Date: Thu, 21 May 2009 17:17:00 -0000 Message-ID: <7230133d0905211017q18062036s9f42f29ea15bebd8@mail.gmail.com> Subject: Re: Question about a comment in _Jv_StackTrace::UnwindTraceFn From: Bryce McKinlay To: Dave Korn Cc: java@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org X-SW-Source: 2009-05/txt/msg00056.txt.bz2 On Thu, May 21, 2009 at 6:02 PM, Dave Korn wrote: > ... but is that the right thing to do? =A0Where should state->interp_fram= e have > been set up? =A0It appears to fix testsuite failures, but I don't know fo= r sure > if they're doing everything right internally. =A0I'll run it through a te= st > cycle if just avoiding the problem in this way is indeed correct, but a > pointer or two could speed me on the way or save me barking up any wrong = trees. Hi Dave state->interp_frame is set in the _Jv_InterpFrame constructor, right at the top of interp-run.cc #ifdef __GCJ_DEBUG _Jv_InterpFrame frame_desc (meth, thread, NULL, &pc); #else _Jv_InterpFrame frame_desc (meth, thread); #endif _Jv_InterpFrame itself is defined in include/java-interp.h Bryce