From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16411 invoked by alias); 4 Sep 2012 17:08:54 -0000 Received: (qmail 16390 invoked by uid 22791); 4 Sep 2012 17:08:52 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_GC X-Spam-Check-By: sourceware.org Received: from mail-ie0-f175.google.com (HELO mail-ie0-f175.google.com) (209.85.223.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Sep 2012 17:08:38 +0000 Received: by iebc11 with SMTP id c11so5796737ieb.20 for ; Tue, 04 Sep 2012 10:08:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.94.195 with SMTP id de3mr15006289igb.68.1346778517974; Tue, 04 Sep 2012 10:08:37 -0700 (PDT) Received: by 10.50.5.163 with HTTP; Tue, 4 Sep 2012 10:08:37 -0700 (PDT) In-Reply-To: <50462ED2.30007@redhat.com> References: <502294A1.3060800@redhat.com> <50243480.7090803@redhat.com> <50254A50.8070208@redhat.com> <50255B35.9020705@redhat.com> <50258712.4070002@redhat.com> <502E6774.8050609@redhat.com> <503F7876.7030606@redhat.com> <503F84A9.8010504@redhat.com> <503F95D8.5010506@redhat.com> <50462ED2.30007@redhat.com> Date: Tue, 04 Sep 2012 17:08:00 -0000 Message-ID: Subject: Re: [PATCH] Set correct source location for deallocator calls From: Bryce McKinlay To: Andrew Haley Cc: Dehao Chen , Richard Henderson , Jason Merrill , Richard Guenther , gcc-patches@gcc.gnu.org, David Li , java@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org X-SW-Source: 2012-09/txt/msg00004.txt.bz2 On Tue, Sep 4, 2012 at 5:39 PM, Andrew Haley wrote: > On 09/04/2012 05:32 PM, Bryce McKinlay wrote: >> On Tue, Sep 4, 2012 at 5:07 PM, Dehao Chen wrote: >>> On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson wrote: >>>> On 08/30/2012 08:20 AM, Andrew Haley wrote: >>>>> Is the problem simply that the logic to >>>>> scan the assembly code isn't present in the libgcj testsuite? >>>> >>>> Yes, exactly. >>> >>> For this case, I don't think that we want a testcase to rely on >>> addr2line in the system. So how about that that we add a test when >>> assembly scan is available in libgcj testsuit? >> >> Once Ian Lance Taylor's libbacktrace patch is integrated (see: >> http://gcc.gnu.org/ml/gcc/2012-08/msg00317.html), we'll be able to get >> rid of the code that calls addr2line from libgcj. > > As I understand it, Ian Taylor's backtrace patch is intended for use in > gcc development, and as he puts it "Since its use in GCC would > be purely for GCC developers, it's not essential that it be fully > portable." Not for gcj runtime. He's also planning to use it for libgo, and other gcc runtime libs have indicated interest. It doesn't have to work on all platforms, and I can't see how it would be any less portable than addr2line! Bryce