From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9180 invoked by alias); 20 Jan 2013 01:16:03 -0000 Received: (qmail 9170 invoked by uid 22791); 20 Jan 2013 01:16:03 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_IB X-Spam-Check-By: sourceware.org Received: from mail-ob0-f182.google.com (HELO mail-ob0-f182.google.com) (209.85.214.182) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 20 Jan 2013 01:15:57 +0000 Received: by mail-ob0-f182.google.com with SMTP id uo13so111896obb.41 for ; Sat, 19 Jan 2013 17:15:57 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.182.42.97 with SMTP id n1mr10530223obl.91.1358644556943; Sat, 19 Jan 2013 17:15:56 -0800 (PST) Received: by 10.76.12.100 with HTTP; Sat, 19 Jan 2013 17:15:56 -0800 (PST) In-Reply-To: <20130119152716.GA4052@bromo.med.uc.edu> References: <20130119152716.GA4052@bromo.med.uc.edu> Date: Sun, 20 Jan 2013 01:16:00 -0000 Message-ID: Subject: Re: shouldfail'ing sourcelocation From: Bryce McKinlay To: Jack Howarth Cc: java@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00007.txt.bz2 On Sat, Jan 19, 2013 at 3:27 PM, Jack Howarth wrote: > How exactly can we shouldfail the sourcelocation test on those > platforms like darwin which don't support dwarf4... This should be an 'xfail', not a 'shouldfail'. Unfortunately I don't think we ever had a mechanism to do platform-specific xfails in the libjava testsuite. You could certainly add that, but maybe just making the line numbers work would be a more productive use of time :) Note you don't need dwarf4 to make sourcelocation work (comment in the test case is a bit misleading). You just need some way to read the source line number info, whatever format it is in.