From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-return-27167-listarch-java=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 22057 invoked by alias); 4 Sep 2012 16:32:46 -0000
Received: (qmail 22038 invoked by uid 22791); 4 Sep 2012 16:32:43 -0000
X-SWARE-Spam-Status: No, hits=-4.6 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_GC
X-Spam-Check-By: sourceware.org
Received: from mail-ie0-f175.google.com (HELO mail-ie0-f175.google.com) (209.85.223.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Sep 2012 16:32:29 +0000
Received: by iebc11 with SMTP id c11so5696119ieb.20        for <multiple recipients>; Tue, 04 Sep 2012 09:32:29 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.50.236.65 with SMTP id us1mr14567426igc.17.1346776348969; Tue, 04 Sep 2012 09:32:28 -0700 (PDT)
Received: by 10.50.5.163 with HTTP; Tue, 4 Sep 2012 09:32:28 -0700 (PDT)
In-Reply-To: <CAO2gOZUxD9-Y3O6iS22HNEHUWaH=0Cm97FZ+KHmhkLmCzahVAA@mail.gmail.com>
References: <CAO2gOZXfnETUe4wqjT7p6fd61hXreu9PDfqKxNz+HxpE0E7K0g@mail.gmail.com>	<CAO2gOZX_hZ1m0xKvxUg+6gWTOX4V5ok-vvCEg3Vhfpt=qXj8-g@mail.gmail.com>	<CAFiYyc00wud5Oa3k51ntm8KeZHZnfm4rpnBsOJjURZMcoqFdTA@mail.gmail.com>	<50228C38.5080703@redhat.com>	<CAO2gOZUbkTsnJ2fwgeNhcRmxkzzJEifECeiF=_YRUjeKDeRMdA@mail.gmail.com>	<502294A1.3060800@redhat.com>	<50243480.7090803@redhat.com>	<CAO2gOZURCuWUk2MVwCwmwrijNzWxJt3q=HUpU7=Qv6zB9e-uqA@mail.gmail.com>	<50254A50.8070208@redhat.com>	<CAO2gOZXhHuFGJ0z=jvkYKZ84EoDaPSYVjxS7QzGore56SyhWyQ@mail.gmail.com>	<50255B35.9020705@redhat.com>	<CAO2gOZWe+qMrVyvOoo7Ek-di0NKZxxU4Z=pqrDCqqCCAfctZOw@mail.gmail.com>	<50258712.4070002@redhat.com>	<CAO2gOZUQQjmKtooyXXAfgFoNVbeNwtT+P=E7pQ6jC=e07Nsr2g@mail.gmail.com>	<CAO2gOZX-Gn+b6LEzps5zxhgmwQWcJ-zFqG=a7hesW6fbVyxZYQ@mail.gmail.com>	<502E6774.8050609@redhat.com>	<CAO2gOZWhueDAShNLbNcJpkHA6QqXk1LNZhEMFvfT77aTZTCH9w@mail.gmail.com>	<503F7876.7030606@redhat.com>	<503F84A9.8010504@redhat.com>	<503F95D8.5010506@redhat.com>	<CAO2gOZUxD9-Y3O6iS22HNEHUWaH=0Cm97FZ+KHmhkLmCzahVAA@mail.gmail.com>
Date: Tue, 04 Sep 2012 16:32:00 -0000
Message-ID: <CALUNu-qXtr3pSTa8j60nD4Y4QK6VNAEOaPh34RRd4qt671gzkA@mail.gmail.com>
Subject: Re: [PATCH] Set correct source location for deallocator calls
From: Bryce McKinlay <bmckinlay@gmail.com>
To: Dehao Chen <dehao@google.com>
Cc: Richard Henderson <rth@redhat.com>, Andrew Haley <aph@redhat.com>, Jason Merrill <jason@redhat.com>, 	Richard Guenther <richard.guenther@gmail.com>, gcc-patches@gcc.gnu.org, 	David Li <davidxl@google.com>, java@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java.gcc.gnu.org>
List-Id: <java.gcc.gnu.org>
List-Subscribe: <mailto:java-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java/>
List-Post: <mailto:java@gcc.gnu.org>
List-Help: <mailto:java-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-owner@gcc.gnu.org
X-SW-Source: 2012-09/txt/msg00002.txt.bz2

On Tue, Sep 4, 2012 at 5:07 PM, Dehao Chen <dehao@google.com> wrote:
> On Thu, Aug 30, 2012 at 9:33 AM, Richard Henderson <rth@redhat.com> wrote:
>> On 08/30/2012 08:20 AM, Andrew Haley wrote:
>>> Is the problem simply that the logic to
>>> scan the assembly code isn't present in the libgcj testsuite?
>>
>> Yes, exactly.
>
> For this case, I don't think that we want a testcase to rely on
> addr2line in the system. So how about that that we add a test when
> assembly scan is available in libgcj testsuit?

Once Ian Lance Taylor's libbacktrace patch is integrated (see:
http://gcc.gnu.org/ml/gcc/2012-08/msg00317.html), we'll be able to get
rid of the code that calls addr2line from libgcj.

So, I think it would be fine to write a Java test case using
Throwable.getStackTrace(). Whichever approach is easiest for you is
fine.

Bryce