From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13376 invoked by alias); 2 Jul 2013 14:53:12 -0000 Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org Received: (qmail 13365 invoked by uid 89); 2 Jul 2013 14:53:12 -0000 X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS,TW_GC autolearn=ham version=3.3.1 Received: from mail-wi0-f172.google.com (HELO mail-wi0-f172.google.com) (209.85.212.172) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Jul 2013 14:53:10 +0000 Received: by mail-wi0-f172.google.com with SMTP id c10so4265901wiw.17 for ; Tue, 02 Jul 2013 07:53:08 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.85.8 with SMTP id d8mr15706309wiz.13.1372776788821; Tue, 02 Jul 2013 07:53:08 -0700 (PDT) Received: by 10.194.83.194 with HTTP; Tue, 2 Jul 2013 07:53:08 -0700 (PDT) In-Reply-To: <51C9A783.40008@redhat.com> References: <51C87C22.9030201@redhat.com> <51C88147.8060508@redhat.com> <51C9A389.6030000@redhat.com> <51C9A53C.20409@redhat.com> <51C9A783.40008@redhat.com> Date: Tue, 02 Jul 2013 14:53:00 -0000 Message-ID: Subject: Re: Trouble building gcj 4.8.1 From: Bryce McKinlay To: Andrew Haley Cc: Mike Hearn , GCC Java Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-07/txt/msg00000.txt.bz2 On Tue, Jun 25, 2013 at 3:21 PM, Andrew Haley wrote: > On 06/25/2013 03:15 PM, Mike Hearn wrote: >>> I'm trying to find out what you want to do to java.lang.String. Tell me >>> that, and we'll take it from there. >> >> At the moment, supporting the methods that take java.nio.Charset. I'm >> going to try and just hack it up with something like this: >> >> public String(byte[] data, int offset, int count, Charset encoding) >> throws UnsupportedEncodingException >> { >> init (data, offset, count, encoding.name()); >> } >> >> and then the same for getBytes(). > > OK. I think you can just add those methods. > >> But in general I anticipate that I'll continue to hit stubs or quirks >> in classpath so I'm trying to figure out how best to reach my goal, >> which will likely involve fixing up various things along the way. For >> instance, my first yak-shaving goal is to run the test suite for the >> core library of this app and then hack/fix until all the tests pass. > > In general, we follow Classpath except for a few core classes -- and > String is one of those. Major hacking on core classes requires compiler > changes, so I strongly recommend you don't do that. For example, better > not add any fields. But in general for almost the whole class library > you won't have so much trouble. I think it's only java.lang.Object and java.lang.Class that are "special" - i.e. could conceivably require compiler changes if you changed the field layout. As far as I can recall, String isn't really treated specially in any way. There should be no problem at all adding those methods and I would encourage you to go ahead and submit a patch. Bryce