From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31523 invoked by alias); 29 Sep 2011 09:32:06 -0000 Received: (qmail 31515 invoked by uid 22791); 29 Sep 2011 09:32:05 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_IB X-Spam-Check-By: sourceware.org Received: from mail-qy0-f182.google.com (HELO mail-qy0-f182.google.com) (209.85.216.182) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Sep 2011 09:31:51 +0000 Received: by qyk4 with SMTP id 4so533409qyk.20 for ; Thu, 29 Sep 2011 02:31:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.199.105 with SMTP id er41mr7672728qcb.69.1317288710353; Thu, 29 Sep 2011 02:31:50 -0700 (PDT) Received: by 10.229.74.81 with HTTP; Thu, 29 Sep 2011 02:31:49 -0700 (PDT) In-Reply-To: <4E8445DE0200007800058686@nat28.tlf.novell.com> References: <4E8445DE0200007800058686@nat28.tlf.novell.com> Date: Thu, 29 Sep 2011 09:32:00 -0000 Message-ID: Subject: Re: libjava build failure with read-only source tree From: Bryce McKinlay To: Jan Beulich Cc: java@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg00022.txt.bz2 On Thu, Sep 29, 2011 at 9:18 AM, Jan Beulich wrote: > --- a/libjava/classpath/tools/Makefile.am > +++ b/libjava/classpath/tools/Makefile.am > @@ -371,6 +371,7 @@ endif > =A0## BEGIN GCJ LOCAL > =A0 =A0 =A0 =A0cp -pR $(srcdir)/asm . > =A0 =A0 =A0 =A0cp -pR $(srcdir)/classes . > + =A0 =A0 =A0 find asm classes -type d -exec chmod u+w \{\} \; > =A0 =A0 =A0 =A0if [ -d asm/.svn ]; then \ > =A0 =A0 =A0 =A0 =A0find asm classes -depth -type d -name .svn -exec rm -r= f \{\} \;; \ > =A0 =A0 =A0 =A0fi This patch looks fine to me, though I wonder if there is any good reason why "cp -p" was used in the first place? In any case, I'd say you can go ahead and check this in under the "obvious" rule. Bryce