From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3976 invoked by alias); 15 Sep 2012 12:55:36 -0000 Received: (qmail 3961 invoked by uid 22791); 15 Sep 2012 12:55:35 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_IB X-Spam-Check-By: sourceware.org Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 15 Sep 2012 12:55:22 +0000 Received: by vcdm8 with SMTP id m8so6544118vcd.20 for ; Sat, 15 Sep 2012 05:55:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.58.147 with SMTP id r19mr4647728veq.5.1347713721147; Sat, 15 Sep 2012 05:55:21 -0700 (PDT) Received: by 10.58.102.100 with HTTP; Sat, 15 Sep 2012 05:55:21 -0700 (PDT) In-Reply-To: References: <50243480.7090803@redhat.com> <50254A50.8070208@redhat.com> <50255B35.9020705@redhat.com> <50258712.4070002@redhat.com> <502E6774.8050609@redhat.com> <503F7876.7030606@redhat.com> <503F84A9.8010504@redhat.com> <503F95D8.5010506@redhat.com> <50463661.1020303@redhat.com> <1346839095.9368.1.camel@springer.wildebeest.org> Date: Sat, 15 Sep 2012 12:55:00 -0000 Message-ID: Subject: Re: [PATCH] Set correct source location for deallocator calls From: "H.J. Lu" To: Andrew Pinski Cc: Dehao Chen , Mark Wielaard , Bryce McKinlay , Andrew Haley , Richard Henderson , Jason Merrill , Richard Guenther , gcc-patches@gcc.gnu.org, David Li , java@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org X-SW-Source: 2012-09/txt/msg00019.txt.bz2 On Fri, Sep 14, 2012 at 9:27 PM, Andrew Pinski wrote: > On Fri, Sep 14, 2012 at 9:25 PM, H.J. Lu wrote: >> On Sat, Sep 8, 2012 at 2:42 PM, Dehao Chen wrote: >>> Hi, >>> >>> I've added a libjava unittest which verifies that this patch will not >>> break Java debug info. I've also incorporated Richard's review in the >>> previous mail. Attached is the new patch, which passed bootstrap and >>> all gcc/libjava testsuites on x86. >>> >>> Is it ok for trunk? >>> >>> Thanks, >>> Dehao >>> >>> gcc/ChangeLog: >>> 2012-09-08 Dehao Chen >>> >>> * tree-eh.c (goto_queue_node): New field. >>> (record_in_goto_queue): New parameter. >>> (record_in_goto_queue_label): New parameter. >>> (lower_try_finally_dup_block): New parameter. >>> (maybe_record_in_goto_queue): Update source location. >>> (lower_try_finally_copy): Likewise. >>> (honor_protect_cleanup_actions): Likewise. >>> * gimplify.c (gimplify_expr): Reset the location to unknown. >>> >>> gcc/testsuite/ChangeLog: >>> 2012-09-08 Dehao Chen >>> >>> * g++.dg/debug/dwarf2/deallocator.C: New test. >>> >>> libjava/ChangeLog: >>> 2012-09-08 Dehao Chen >>> >>> * testsuite/libjava.lang/sourcelocation.java: New cases. >>> * testsuite/libjava.lang/sourcelocation.out: New cases. >> >> On Linux/x86, I got >> >> FAIL: sourcelocation -O3 -findirect-dispatch output - source compiled test >> FAIL: sourcelocation -O3 output - source compiled test >> FAIL: sourcelocation -findirect-dispatch output - source compiled test >> FAIL: sourcelocation output - source compiled test >> >> spawn [open ...]^M >> -1 >> -1 >> -1 >> PASS: sourcelocation -findirect-dispatch execution - source compiled test >> FAIL: sourcelocation -findirect-dispatch output - source compiled test > > I bet you have an older addr2line installed. > I am using addr2line from binutils 20120914. -- H.J.