From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-return-27181-listarch-java=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 341 invoked by alias); 15 Sep 2012 04:25:24 -0000
Received: (qmail 32755 invoked by uid 22791); 15 Sep 2012 04:25:19 -0000
X-SWARE-Spam-Status: No, hits=-3.8 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_IB
X-Spam-Check-By: sourceware.org
Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 15 Sep 2012 04:25:06 +0000
Received: by obblz20 with SMTP id lz20so8093013obb.20        for <multiple recipients>; Fri, 14 Sep 2012 21:25:05 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.60.25.226 with SMTP id f2mr6183552oeg.53.1347683105319; Fri, 14 Sep 2012 21:25:05 -0700 (PDT)
Received: by 10.76.10.6 with HTTP; Fri, 14 Sep 2012 21:25:05 -0700 (PDT)
In-Reply-To: <CAO2gOZVhW2+VfKU8+n2qrcKr9fgM1G4bRyUTUB_0DATH9eEW6w@mail.gmail.com>
References: <CAO2gOZXfnETUe4wqjT7p6fd61hXreu9PDfqKxNz+HxpE0E7K0g@mail.gmail.com>	<50243480.7090803@redhat.com>	<CAO2gOZURCuWUk2MVwCwmwrijNzWxJt3q=HUpU7=Qv6zB9e-uqA@mail.gmail.com>	<50254A50.8070208@redhat.com>	<CAO2gOZXhHuFGJ0z=jvkYKZ84EoDaPSYVjxS7QzGore56SyhWyQ@mail.gmail.com>	<50255B35.9020705@redhat.com>	<CAO2gOZWe+qMrVyvOoo7Ek-di0NKZxxU4Z=pqrDCqqCCAfctZOw@mail.gmail.com>	<50258712.4070002@redhat.com>	<CAO2gOZUQQjmKtooyXXAfgFoNVbeNwtT+P=E7pQ6jC=e07Nsr2g@mail.gmail.com>	<CAO2gOZX-Gn+b6LEzps5zxhgmwQWcJ-zFqG=a7hesW6fbVyxZYQ@mail.gmail.com>	<502E6774.8050609@redhat.com>	<CAO2gOZWhueDAShNLbNcJpkHA6QqXk1LNZhEMFvfT77aTZTCH9w@mail.gmail.com>	<503F7876.7030606@redhat.com>	<503F84A9.8010504@redhat.com>	<503F95D8.5010506@redhat.com>	<CAO2gOZUxD9-Y3O6iS22HNEHUWaH=0Cm97FZ+KHmhkLmCzahVAA@mail.gmail.com>	<CALUNu-qXtr3pSTa8j60nD4Y4QK6VNAEOaPh34RRd4qt671gzkA@mail.gmail.com>	<CALUNu-p2-rvGCLYn9s1gy-rGOq+cOwZCw9S1Twbjcba0dVKTfQ@mail.gmail.com>	<50463661.1020303@redhat.com>	<CALUNu-oP9dqG63EHyN18gYj4P3gwrrJcp4Zgrz-pABNxabmsCg@mail.gmail.com>	<1346839095.9368.1.camel@springer.wildebeest.org>	<CAO2gOZVhW2+VfKU8+n2qrcKr9fgM1G4bRyUTUB_0DATH9eEW6w@mail.gmail.com>
Date: Sat, 15 Sep 2012 04:25:00 -0000
Message-ID: <CAMe9rOqpzNa-u7b-nUfeBkpSed5Fkh16tzw4_uyptpMpKfhUfA@mail.gmail.com>
Subject: Re: [PATCH] Set correct source location for deallocator calls
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Dehao Chen <dehao@google.com>
Cc: Mark Wielaard <mark@klomp.org>, Bryce McKinlay <bmckinlay@gmail.com>, Andrew Haley <aph@redhat.com>, 	Richard Henderson <rth@redhat.com>, Jason Merrill <jason@redhat.com>, 	Richard Guenther <richard.guenther@gmail.com>, gcc-patches@gcc.gnu.org, 	David Li <davidxl@google.com>, java@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java.gcc.gnu.org>
List-Id: <java.gcc.gnu.org>
List-Subscribe: <mailto:java-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java/>
List-Post: <mailto:java@gcc.gnu.org>
List-Help: <mailto:java-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-owner@gcc.gnu.org
X-SW-Source: 2012-09/txt/msg00016.txt.bz2

On Sat, Sep 8, 2012 at 2:42 PM, Dehao Chen <dehao@google.com> wrote:
> Hi,
>
> I've added a libjava unittest which verifies that this patch will not
> break Java debug info. I've also incorporated Richard's review in the
> previous mail. Attached is the new patch, which passed bootstrap and
> all gcc/libjava testsuites on x86.
>
> Is it ok for trunk?
>
> Thanks,
> Dehao
>
> gcc/ChangeLog:
> 2012-09-08  Dehao Chen  <dehao@google.com>
>
>          * tree-eh.c (goto_queue_node): New field.
>         (record_in_goto_queue): New parameter.
>         (record_in_goto_queue_label): New parameter.
>         (lower_try_finally_dup_block): New parameter.
>         (maybe_record_in_goto_queue): Update source location.
>         (lower_try_finally_copy): Likewise.
>         (honor_protect_cleanup_actions): Likewise.
>         * gimplify.c (gimplify_expr): Reset the location to unknown.
>
> gcc/testsuite/ChangeLog:
> 2012-09-08  Dehao Chen  <dehao@google.com>
>
>         * g++.dg/debug/dwarf2/deallocator.C: New test.
>
> libjava/ChangeLog:
> 2012-09-08  Dehao Chen  <dehao@google.com>
>
>         * testsuite/libjava.lang/sourcelocation.java: New cases.
>         * testsuite/libjava.lang/sourcelocation.out: New cases.

On Linux/x86, I got

FAIL: sourcelocation -O3 -findirect-dispatch output - source compiled test
FAIL: sourcelocation -O3 output - source compiled test
FAIL: sourcelocation -findirect-dispatch output - source compiled test
FAIL: sourcelocation output - source compiled test

spawn [open ...]^M
-1
-1
-1
PASS: sourcelocation -findirect-dispatch execution - source compiled test
FAIL: sourcelocation -findirect-dispatch output - source compiled test


-- 
H.J.