From: Tom Tromey <tromey@redhat.com>
To: Dave Korn <dave.korn.cygwin@googlemail.com>
Cc: Ben Elliston <bje@au1.ibm.com>, java <java@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Andrew Haley <aph@redhat.com>
Subject: Re: PATCH, libjava: silence more warnings
Date: Tue, 01 Dec 2009 19:44:00 -0000 [thread overview]
Message-ID: <m3d42yo4xf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4B1564E4.6060009@gmail.com> (Dave Korn's message of "Tue, 01 Dec 2009 18:48:04 +0000")
>>>>> "Dave" == Dave Korn <dave.korn.cygwin@googlemail.com> writes:
Dave> Ben Elliston wrote:
>> ::java::lang::String *
>> -java::net::VMURLConnection::guessContentTypeFromBuffer (jbyteArray bytes,
>> - jint valid)
>> +java::net::VMURLConnection::guessContentTypeFromBuffer (jbyteArray bytes __attribute__ ((unused)),
>> + jint valid __attribute__ ((unused)))
Dave> There's a #define MAYBE_UNUSED in include/jvm.h, as used in
Dave> java/lang/natClass.cc. But maybe jvm.h isn't available here?
It is ok to include jvm.h from any of the CNI code.
But, it is also ok to just use an unadorned __attribute__. We know this
code can only be compiled by g++.
Tom
next prev parent reply other threads:[~2009-12-01 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 18:22 Ben Elliston
2009-12-01 18:32 ` Dave Korn
2009-12-01 19:44 ` Tom Tromey [this message]
2009-12-01 20:15 ` Dave Korn
2009-12-01 18:49 ` Andrew Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d42yo4xf.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=aph@redhat.com \
--cc=bje@au1.ibm.com \
--cc=dave.korn.cygwin@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=java@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).