* Patch for _Jv_CheckOrCreateLoadingConstraint
@ 2009-03-11 17:38 Andrew Haley
2009-03-11 18:07 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Haley @ 2009-03-11 17:38 UTC (permalink / raw)
To: Tom Tromey; +Cc: GCJ
Maven2 doesn't build at the moment because our code to check the loading
constraints (Section 5.3.4, JVM Spec Second Edition) is wrong.
Tom, is this the correct fix?
Andrew.
2009-03-11 Tom Tromey <tromey@redhat.com>
* link.cc (_Jv_Linker::find_field): Pass the field_type to
_Jv_CheckOrCreateLoadingConstraint, not the class that is
requesting the field.
--- link.cc~ 2009-01-14 11:10:39.000000000 +0000
+++ link.cc 2009-03-11 17:33:31.000000000 +0000
@@ -248,7 +248,7 @@ _Jv_Linker::find_field (jclass klass, jc
// Note that the field returned by find_field_helper is always
// resolved. However, we still use the constraint mechanism
// because this may affect other lookups.
- _Jv_CheckOrCreateLoadingConstraint (klass, (*found_class)->loader);
+ _Jv_CheckOrCreateLoadingConstraint (field_type, (*found_class)->loader);
}
else
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Patch for _Jv_CheckOrCreateLoadingConstraint
2009-03-11 17:38 Patch for _Jv_CheckOrCreateLoadingConstraint Andrew Haley
@ 2009-03-11 18:07 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2009-03-11 18:07 UTC (permalink / raw)
To: Andrew Haley; +Cc: GCJ
>>>>> "Andrew" == Andrew Haley <aph@redhat.com> writes:
Andrew> Maven2 doesn't build at the moment because our code to check the loading
Andrew> constraints (Section 5.3.4, JVM Spec Second Edition) is wrong.
Andrew> Tom, is this the correct fix?
Yes.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-11 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-11 17:38 Patch for _Jv_CheckOrCreateLoadingConstraint Andrew Haley
2009-03-11 18:07 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).