libjava testsuite nit

libjava testsuite nit

[Ben Elliston]

Hi.

I noticed that the libjava testsuite emits the full pathname of various
files in the test output (ie. the argument to dejagnu's
pass/fail/untested/etc. procedures).  Here are some examples:

PASS: /home/bje/source/gcc-nas/libjava/testsuite/libjava.jar/TestClosureGC.jar execution - gij test
PASS: /home/bje/source/gcc-nas/libjava/testsuite/libjava.jar/TestClosureGC.jar output - gij test
PASS: /home/bje/source/gcc-nas/libjava/testsuite/libjava.jar/simple.jar execution - gij test
PASS: /home/bje/source/gcc-nas/libjava/testsuite/libjava.jar/simple.jar output - gij test

The problem with this is that it confuses the contrib/compare_tests
script, because when you are comparing two builds from two different
source trees, the paths are different.  compare_tests gives output to
the effect that some tests have vanished and others have appeared out of
nowhere.

Would it be satisfactory to use Tcl's "file tail" command to lop off the
paths, leaving just the base filenames in the test output?  I'm just
wondering why it was done this way in the first place?

Thanks,
Ben

Re: libjava testsuite nit

[Ben Elliston]

On Fri, 2008-08-08 at 08:25 +0100, Bryce McKinlay wrote:

> I suppose this was to make it easy to locate the offending test in the
> event of a failure. There might be test cases with similar names in
> different paths. I don't see a problem stripping the path in the pass
> case, though. Maybe just report the full path when a test fails.

Oh, good thinking.  Let's try that.

Cheers, Ben

Re: libjava testsuite nit

[Tom Tromey]

>>>>> "Ben" == Ben Elliston <bje@au1.ibm.com> writes:

Bryce> I suppose this was to make it easy to locate the offending test in the
Bryce> event of a failure. There might be test cases with similar names in
Bryce> different paths. I don't see a problem stripping the path in the pass
Bryce> case, though. Maybe just report the full path when a test fails.

Ben> Oh, good thinking.  Let's try that.

It would also be fine by me if you just had it strip everything before
the 'testsuite' component, or keep the last 3 path components, or
something along those lines.

Tom