From: Ian Lance Taylor <iant@google.com>
To: Martin Thuresson <martin@mtme.org>
Cc: Matthias Klose <doko@ubuntu.com>, Nick Clifton <nickc@redhat.com>,
binutils <binutils@sourceware.org>,
Tristan Gingold <gingold@adacore.com>,
GCC Java <java@gcc.gnu.org>
Subject: Re: [regressions in GCC/libjava testsuite] Re: Patch to make bfd compile with -Wc++-compat
Date: Thu, 01 Oct 2009 00:56:00 -0000 [thread overview]
Message-ID: <mcrvdj0vso5.fsf@dhcp-172-17-9-151.mtv.corp.google.com> (raw)
In-Reply-To: <624836f10909301745k5ffdcc77s1d8d0262093fc38c@mail.gmail.com> (Martin Thuresson's message of "Wed\, 30 Sep 2009 17\:45\:55 -0700")
Martin Thuresson <martin@mtme.org> writes:
> Here is a patch that fixes a bug introduced with my patch. Im sorry
> for the first mistake.
> I was unable to run make check on my mac laptop, but will do it on my
> linux box in 30 min
> or so.
I was talking about this with Alan on IRC. The bug is actually this
change:
2002-10-07 Gordon Chaffee <chaffee@netvmg.com>
* addr2line.c (slurp_symtab): Read in dynamic symbols if no
ordinary ones are available.
That patch was 100% bogus. We shouldn't be trying to break the
minisyms interface here. For some reason I can't find the e-mail in
the binutlis mailing list archive.
Ian
next prev parent reply other threads:[~2009-10-01 0:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <624836f10909071812q358c0ff8p34ce468ccadb50@mail.gmail.com>
[not found] ` <m3pra1w0t9.fsf@google.com>
[not found] ` <624836f10909082138h1e14eb14j76d08ba0e4d76d0a@mail.gmail.com>
[not found] ` <624836f10909082308p349131c5l103efc029e9e26e0@mail.gmail.com>
[not found] ` <4AA820CB.3030403@redhat.com>
2009-09-30 23:01 ` Matthias Klose
2009-09-30 23:23 ` Matthias Klose
2009-09-30 23:48 ` Alan Modra
2009-10-01 0:04 ` Alan Modra
2009-10-01 0:20 ` Martin Thuresson
2009-10-01 0:34 ` Dave Korn
2009-10-01 0:46 ` Martin Thuresson
2009-10-01 0:56 ` Ian Lance Taylor [this message]
2009-10-01 1:14 ` Matt Rice
2009-10-01 5:37 ` Alan Modra
2009-10-01 11:35 ` Matthias Klose
2009-10-01 1:36 ` Martin Thuresson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mcrvdj0vso5.fsf@dhcp-172-17-9-151.mtv.corp.google.com \
--to=iant@google.com \
--cc=binutils@sourceware.org \
--cc=doko@ubuntu.com \
--cc=gingold@adacore.com \
--cc=java@gcc.gnu.org \
--cc=martin@mtme.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).