From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22708 invoked by alias); 1 Oct 2009 00:56:12 -0000 Received: (qmail 22692 invoked by uid 22791); 1 Oct 2009 00:56:11 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Oct 2009 00:56:06 +0000 Received: from zps35.corp.google.com (zps35.corp.google.com [172.25.146.35]) by smtp-out.google.com with ESMTP id n910u29L026262 for ; Thu, 1 Oct 2009 01:56:02 +0100 Received: from pxi8 (pxi8.prod.google.com [10.243.27.8]) by zps35.corp.google.com with ESMTP id n910soGe010457 for ; Wed, 30 Sep 2009 17:55:59 -0700 Received: by pxi8 with SMTP id 8so7769419pxi.27 for ; Wed, 30 Sep 2009 17:55:59 -0700 (PDT) Received: by 10.114.214.24 with SMTP id m24mr890166wag.93.1254358559379; Wed, 30 Sep 2009 17:55:59 -0700 (PDT) Received: from coign.google.com ([67.218.104.42]) by mx.google.com with ESMTPS id 21sm229893pxi.11.2009.09.30.17.55.57 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 30 Sep 2009 17:55:58 -0700 (PDT) To: Martin Thuresson Cc: Matthias Klose , Nick Clifton , binutils , Tristan Gingold , GCC Java Subject: Re: [regressions in GCC/libjava testsuite] Re: Patch to make bfd compile with -Wc++-compat References: <624836f10909071812q358c0ff8p34ce468ccadb50@mail.gmail.com> <624836f10909082138h1e14eb14j76d08ba0e4d76d0a@mail.gmail.com> <624836f10909082308p349131c5l103efc029e9e26e0@mail.gmail.com> <4AA820CB.3030403@redhat.com> <4AC3E34D.3080708@ubuntu.com> <4AC3E875.1010007@ubuntu.com> <20090930234835.GC18973@bubble.grove.modra.org> <20091001000428.GD18973@bubble.grove.modra.org> <624836f10909301720u26dcf05eu684b54edd3315fd9@mail.gmail.com> <624836f10909301745k5ffdcc77s1d8d0262093fc38c@mail.gmail.com> From: Ian Lance Taylor Date: Thu, 01 Oct 2009 00:56:00 -0000 In-Reply-To: <624836f10909301745k5ffdcc77s1d8d0262093fc38c@mail.gmail.com> (Martin Thuresson's message of "Wed\, 30 Sep 2009 17\:45\:55 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg00004.txt.bz2 Martin Thuresson writes: > Here is a patch that fixes a bug introduced with my patch. Im sorry > for the first mistake. > I was unable to run make check on my mac laptop, but will do it on my > linux box in 30 min > or so. I was talking about this with Alan on IRC. The bug is actually this change: 2002-10-07 Gordon Chaffee * addr2line.c (slurp_symtab): Read in dynamic symbols if no ordinary ones are available. That patch was 100% bogus. We shouldn't be trying to break the minisyms interface here. For some reason I can't find the e-mail in the binutlis mailing list archive. Ian