From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <10walls@gmail.com> Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by sourceware.org (Postfix) with ESMTPS id 8AF653851C2B; Tue, 2 Jun 2020 16:27:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8AF653851C2B Received: by mail-pf1-x444.google.com with SMTP id v2so5270441pfv.7; Tue, 02 Jun 2020 09:27:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to; bh=rF+1lN4VSZvO6z+3H5Wx720HDn85oRgXycWwoseQAFA=; b=UuIUHgvXocXRM1MgRKRherWNYxEwmM4CmFqKelz1C6MpjwJFdJ+YtrlzCsvTYotpcP RPfcirgNwZqGHUe4JkXM5vqOLaJ8Cyjl10VONimaMIrke1Urat3/W4/6O042u+YgWBGV kLbPuXxdXFRU6H2tiblAuEO/IJ/Mua4lLy7/rXfznadhbhWJ7Id85MgADz7PqI6IBRK+ loanSMeag5MoST5PIqVRUQ+trms1dLhlajUs5Rt135pz2pHORFhild7O9FMeW1Hd0cok IZn47gSuqbVVLgsCPXqQ3nW9ViBjRlRC7IAucikEXvy2IBcxM9TYSVDOCGjE8MiH9umW EJLw== X-Gm-Message-State: AOAM5308X8H2lsSUzo/jpaDzt3QhSvQqS8BCFvT802J+RD+jvQ3zJ5hz rer8XRtZLMLG2LdCalGkyHc3Oc0v X-Google-Smtp-Source: ABdhPJw7xKRW5ZZoHS7eywSneRQvRMU0ol3Ti3Gd50MBZjeOulxH6i8JD/Dwpie8+LBuuOqex1RD9w== X-Received: by 2002:aa7:8ecd:: with SMTP id b13mr10706269pfr.297.1591115229265; Tue, 02 Jun 2020 09:27:09 -0700 (PDT) Received: from ?IPv6:2001:f40:91b::2:94dc? ([2001:f40:91b::2:94dc]) by smtp.gmail.com with ESMTPSA id u1sm2478272pgf.28.2020.06.02.09.27.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2020 09:27:08 -0700 (PDT) Subject: Re: [PATCH] Port libgccjit to Windows. To: David Malcolm , =?UTF-8?Q?Nicolas_B=c3=a9rtolo?= Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <4b619179a08075bd2ee7f9e98aa2d5918191306d.camel@redhat.com> <5de2a5202b50882612e1fe51d254f2b125f61716.camel@redhat.com> <885d0b34df56c30f25c2ba57f4eecf517d1ba05c.camel@redhat.com> <5edb0f517d11a551f622ebb787fc06cd6c06225b.camel@redhat.com> From: JonY <10walls@gmail.com> Autocrypt: addr=10walls@gmail.com; prefer-encrypt=mutual; keydata= mQINBFDEdwIBEACSrmywJMpgYlgJa0HJ1AFu9tQp8yVpVS21EfnrSK16TS6PoW/JS78D5CYx pshPzr1iil8yeL8/val1yXkI8uNZjMnhLxMBU5C7WEMCeY/h760btG3bZZ5BMCNCkC0Yfrtv JJQDEyv1H+p1U7yMFRyxNtMjaf6QDzoRjTVOzO6mtNMZWYnlhzC54etiVt3HQ4jKOlKbI+dw jigIw8B1SZ+xWcukAHRMBcIZYLjbnAI/XNu796pfwh6QEhJjr8EpvyNjdHLFSMMuyUPO/a3s r/jkFSTpqt5lr9jWejdQwe7e8WtbC+euv++fH1B9Yz42259kLxgH+aHk6lWX3epIIx3w17rG faMrFrINjXEBGLLOQkIy2LtBLYRU2NhDg+VSDOEwAsiOVZs1EHpSNF5GV12L8SFiNtVToHxL RpObNpYIHBkDFzx9gvQfX5Kocx5XFhBiNfTjdxBOjopLzQHpfCSo3fzSqc7zpscqOw3uni7G IN86fI8h3wSV44dQ4yaervnL2kZykRyWL5y1C9WDfjzljTIeLB6gK/gBbrsuKuVC42r6xAK9 yC9pL0Trf7+GLJ9UF4WGnJ5IvfVpZ7gtBMjWOpiwewTprdBNwhLsVSep9Vqg/cbtmG6AnpzN tMsLEWAwDpgaFa5KqlehgUCuMlEdU6LhvSd0cJ/pqKwwzxEiLwARAQABtBlqb25feSA8MTB3 YWxsc0BnbWFpbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgBYh BOUK3Z2wV/T6ZOG2z3E7X+KcFF1FBQJb/k5NBQkUn9jLAAoJEHE7X+KcFF1FVlkP/jwLb9aa b268Q3XQnocIDD7HArFnzKyvIvIndqGuGs51u+6p8I+zBKHIyF4T9E1mkXfq2bRIbvKojrkA Gi7KgCePKHRILVtfiAANSJtj9304WcUYIiD3vLHgB0Hiv5AUc3YWntnaznKh8VMLMx/ANf3/ OjeldikLunkC7vu/YwhbdsPWDEn7v47FsllqhbLbjsm+trboiORJMUzAdJ65yv2WvRKnsRLd rXSyXxcW651XiNstVpgCqGkZP1PUSxUX8SvA/UzVXC4rw0nHaVVlB5JovywL/Y/3GG6q3/x6 hXWgqDBB68GvlQLA39JRGq6ELwwE9mo5EzU4q6a1Y2Uy1ZKqJ56xs+peI5qJdFtIfXcPX2e6 wdaCW631HcgJpykIS/gwDIsxI8NhfmiDLXY1sWnKDU0hjIwDEP/fjLtHp2o1TFBzBMX94/CL i4kt2jhPZqhZed/unJ3IVtpwfi7Lum5LuNQhHqPF8U2YGJfIwaap6KUThy3CffPBhzSyQbTl izhP9hAGaMqh9NomJn+YIJlJEYoRkubcaQ95Vev4K0y3LNklxbePo2Jwd+ovxprS6NeJJaRT VpR8ZO58RD5B/1oKTW6udVQIeNATjkwoDSR6fi9s7sLLfCVy4404hYuzvrlm4QF3gruz4qhL 4w1SG0lddEGhMderspH9WtQs4H7etCFKb25hdGhhbiBZb25nIDwxMHdhbGxzQGdtYWlsLmNv bT6JAlYEEwECAEACGwMHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgBYhBOUK3Z2wV/T6ZOG2 z3E7X+KcFF1FBQJb/k5ZBQkUn9jLAAoJEHE7X+KcFF1Fl/QP/iRjpleVIfhN0ZAUS+NM5A2K 6LYynLocmY9pNjjH9674zWl5zhs2lOI/XKFBJZDZpcIFCPx0kQBivvVYL7f5cSvZ1pWJ+W7Y MD7nNGBc0lkMktgMJUlL4QzVfjeHJRURw4bUsvScH+9n1BhEiCH6P3Q0ddDkxdhwzNBL/66t HSA2wwTgrAttAZt3x4Ah7SM27SUR2o2MfFLSU8PiYTZnXnedC+dbEUCZtRgppLICRQ065Wq4 ZGThSxL3gmXg/yudnX4dLCIlBdBK4xgRKOaCRPDfsFRyZRd+HeqJhkEyr03TbtAWie1WYgKc 16yxXKo9D1EKP3pi67/QGMhpnpv1WNzs78su38aDEYh156vyTu7cTdDKHC2/EkOUn6SOEeNi akdLMgNEIuobCaTgUqeuSqHj2PbWCHZhaZnuQnetwSPHrA8nx/FqhUEAiDezNuykapHVgpbV wx+zvmEW8wyuM6IZOBdTB2NHlA675r7bJ4CmRnTNF8fNVxL15bHIwY+Tt9zS2SlDTu4GLdxb Ww5XQf42gh22INeSKFvw37NeLP+pnB2Pn+GJhwHngmPEALOThXcMq7g0IgCR+4xMEihORQV1 GmeBoLcl/Q8z0G/VtKY0xJAYRaMoc5ScLr7GLYOF8Xn08Zkisdp3V1ralUXRIWcQ8IwkbiJe JxPDfq2slh+uuQINBFDEdwIBEACsXcBns4YGVTUGMVKVGEocPffmAhAY89XSk1c1qWPngieU tZ2GoiG+a8IKAqYIjfpuV/YXX8i9mXuGAGJvf6rRhpPos8v76y3qoFFrPsFjNaiTTTvPn1oN RT+Br5KWjJaDomGkmQe5bGrok6ETK4VgRdYWPib7IbTLUX1rzfaKvDP219HTsdWj/cdE3QGT ZjekJUiJqgqSS8SmaBNtFm2T18r3gdx6+Xq0kJPW421IaXtuxbyD3MTBVJYEfY+rEvVfMUi9 rvsfCG0djJOh8954D8AhVY58x7aszhHddTeQlXxUdwNpyJFFoFFhpj0LvmhCH84eaf+9eW8V qegPDzE2MJ/Oe+bftYS9qtIx4MMHRU5Wl7g2x3QUhsmyev3BmhBvqFzo6TmBZ1bjp2MXZqQw 2d5YXJNb0Vtr9qgV1EqnoG7Lf5q5wcENYAJDVeOzOMxUnM3u2VYbt8GMu3QITxpHw4lOukza rmEmAq3EwwzBxFKKmD9gvAbkAGmimONRiQSY9OBEW4XLmOqy9b7pnoS+6x0Oqv8lELvz9TJ2 Kh5urXJ/7LOvof9z3R0g7Hn7AWn1Y+0hUKN1vRqziJdIFqZ7kcViiKYAKfYiDPlHSAVguc3q vok0P8A3uS5qvkz2yC3C5Jt913FoNVu3ny0/UCDjpSAqC3qTXMx3otwLDLv/dwARAQABiQI8 BBgBAgAmAhsMFiEE5QrdnbBX9Ppk4bbPcTtf4pwUXUUFAlv+TloFCRSf2NgACgkQcTtf4pwU XUWzcw//ckxWc2Zyd58jjZxpMG1hpGHJVMyi+1aC12mCozlKuGDUBhbEbs6z8INlAQh9ic5d h9jXW8WclJglzo1Bm1naQOUmCFLh2WgV/0Om9vqDeJ0r5J2xcoBesiAflt/2dBHn3sZHivwq 46c2/pMl95LAoA9z+4lZLBCjL64wo9QZujrDoSlUTKMnmfTKYzvUqF4Y7394b3cwi4WNlR3C eqAzU5f+RjGlIpCTP2h+ui7L8JvPCBLzy6lcEm6NJayUIMDyFKYtlJdiPOVtSveZyrFjx6qW rIHogOXTorTZrtysBi8gAoU+7h7dOBswi0vnjftyH7S6M8N0K+LKnRj8zBjajyAcBRuvXP+t fvIPHUMnkWifgMLhrMUgTZHX4V4DVjNHzVuAxr+yIHGLUgn6sSrYnYX8aCK37cByLO78563L aT/p7WD56R5grBe0HEaoarixVmovv4GzI3GGNLBx+GraRAtvbPsol0sZ0OZWKWVL1/meHi7F e5EFYeoI5/xANT1Xm+GMnLGrt6CH44FaJ0rUQ900ZGf69laS+pniyasFgdtiUeCLCcUww9k6 jUq5Sa1npJYFVJqnuush2cUXWG5Z9DFZ2Jg7LWvZqUc2rt0B8+AIWWfEGNoh3KgziYAnpr+5 iH7wMIsgvMwRrJmB2S4ixQUNVeE06B+VUDKv1BkfmRE= Message-ID: <01bd8894-78f7-47b4-1a38-e062d549450b@gmail.com> Date: Tue, 2 Jun 2020 16:26:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <5edb0f517d11a551f622ebb787fc06cd6c06225b.camel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KKLQYxslmYiNntCdWghcEpz9IHMxlj2Gg" X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 16:27:11 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KKLQYxslmYiNntCdWghcEpz9IHMxlj2Gg Content-Type: multipart/mixed; boundary="bGusdRSnq4BAirHi3EAP7coFD2SH1zbbH"; protected-headers="v1" From: JonY <10walls@gmail.com> To: David Malcolm , =?UTF-8?Q?Nicolas_B=c3=a9rtolo?= Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Message-ID: <01bd8894-78f7-47b4-1a38-e062d549450b@gmail.com> Subject: Re: [PATCH] Port libgccjit to Windows. References: <4b619179a08075bd2ee7f9e98aa2d5918191306d.camel@redhat.com> <5de2a5202b50882612e1fe51d254f2b125f61716.camel@redhat.com> <885d0b34df56c30f25c2ba57f4eecf517d1ba05c.camel@redhat.com> <5edb0f517d11a551f622ebb787fc06cd6c06225b.camel@redhat.com> In-Reply-To: <5edb0f517d11a551f622ebb787fc06cd6c06225b.camel@redhat.com> --bGusdRSnq4BAirHi3EAP7coFD2SH1zbbH Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/28/20 8:46 PM, David Malcolm via Gcc-patches wrote: > On Thu, 2020-05-28 at 16:51 -0300, Nicolas B=C3=A9rtolo wrote: >>> I'm going to have to trust your Windows expertise here; the tempdir >>> code looks convoluted to me, but perhaps that's the only way to do >> it. >>> (Microsoft's docs for "SECURITY_ATTRIBUTES" suggest to me that if >>> lpSecurityDescriptor is NULL, then the directory gets a default >>> security descriptor, and that this may mean it's only readable by >> the >>> user represented by the access token of the process [1], which >> might >>> suggest a simplification - but I'm very hazy on how the security >> model >>> in Windows works) >> >> I tested this and it gives write access to the "Authenticated Users" >> group.=20 >=20 > Aha - sounds like that would be a problem. Thanks for clarifying. >=20 >> The >> way I did it gives access only to the user that owns the libgccjit >> process. I >> have to admit that it is a lot of code and it is hard to understand >> unless you >> know the security model of Windows well. I don't know it well, I >> wrote this >> keeping the documentation close and experimenting. >=20 > Thanks. >=20 >>> I was able to successfully bootstrap and regression test with your >>> patch on x86_64-pc-linux-gnu. I also verified that the result of >> "make >>> install" was not affected for my configuration. >> >> Great. >> >>> I've pushed your patch to master as >>> c83027f32d9cca84959c7d6a1e519a0129731501. >>> >>> Thanks again for the patch >>> Dave >> >> Thanks to you for all the good feedback. >> >> Nico. >=20 Hello, A bit of a late review, some minor points: 1. Using .so on Windows for DLLs is fine. 2. The DLL name on Windows should use LIBGCCJIT_SONAME rather than LIBGCCJIT_LINKER_NAME, so applications would load libgccjit.so.0 instead of libgccjit.so directly. The linker command output needs to be LIBGCCJIT_SONAME. 3. Ideally I would prefer to .cc too, though I see other C++ files also written as .c. Resend in case reply to list did not work, --bGusdRSnq4BAirHi3EAP7coFD2SH1zbbH-- --KKLQYxslmYiNntCdWghcEpz9IHMxlj2Gg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5QrdnbBX9Ppk4bbPcTtf4pwUXUUFAl7WfdIACgkQcTtf4pwU XUXSQg//Qe4skc9mymULsfXaYZVOPH1qJ93ZMDy7ZvTLxz1nh8Ffd2pY1DhjOjD+ abPWxgfDdP5BhfpMlON/dA88QB/Qk9VgeiJIdcSYF2+hs7HR5JO3m4rdG5iT+9dn 3aEBwCnoVmZZtBrmW4iasMAJW/10LYTq1OUPcINPIubrNJCzO8f3Y09WItk7YCnN mDNGCWaeYOhTL/g7xmhJNDN/yHnENylmeWHPTA7OQJ4UMHeyCrdUbQFTF9jInMet c2bGMmbQ/XpZMlqkAcPTNqsXXHREoMKlFkg7hWcLsbz8johnUWiu0JeekWnLQ/rZ ej9ZDUmfxAQjJQnZ5byBQj+qWDIXGlx1VUPlB3r6hJC3nbhg2qy3VBvHSjZtpnCz pzjLWKX1SBiVKELA216ViJhf1DBlb3ZAGM3baVXKh7kdgqwo98BhpE+jm++mN8ih mIkCdGAwMQU0qYWidPcUjuDV9iP0YTCfi+EIpGx8bQtMenFl7kjkEIyYxkvdi3Y0 UD1oy3ahVfjThN1MtWXhyvurPMYgbKhkiCqgBklIQsx7pVNo4fmtPbawCG1Dv8Y5 40Erx89zsB1MpGY5DMkjLQFmnr/C7kXSJx4xsBLKR7IICGVZiOV9FQPYYpyFhyCq W7RGzqGdT/gAv+cC2LUflgeyNpn3yrx12PBby68O7OuxNAgXY1w= =8Y00 -----END PGP SIGNATURE----- --KKLQYxslmYiNntCdWghcEpz9IHMxlj2Gg--