From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 48E4C383C7CE for ; Tue, 13 Dec 2022 21:24:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 48E4C383C7CE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670966648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WE1mJSWSifVq7gLJCWqVSWZ319J4Xbp0Vwux8ottgmE=; b=TXst3GWTyNhFebATswbpfeE883cuun9by0tjBLVLl+FllqPExaimY7TbkAfyIysLs1iy2h 9dR863dhZJigIzqEWN7rBjzlM2ZW8CjxfRK42A3m99kkWMd1uo5fW29xOVw33Y3mxv0JmY M+i4XeedbcIQsnGtsBYP7DoI/1LzZdQ= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-665-NRzF_kLPPkSBz2uvAVUp1w-1; Tue, 13 Dec 2022 16:24:07 -0500 X-MC-Unique: NRzF_kLPPkSBz2uvAVUp1w-1 Received: by mail-vs1-f69.google.com with SMTP id b68-20020a676747000000b003b364361173so2425703vsc.3 for ; Tue, 13 Dec 2022 13:24:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WE1mJSWSifVq7gLJCWqVSWZ319J4Xbp0Vwux8ottgmE=; b=RPGprMQ4ohu0I10lOdCmA03TcrDH+663tzwKFw05DeAcA74PAWWzNu0jpXibHf7D7G EnhXT62tbF5xKSO2N6EoW5jc79CVe16aQ1DlmhY4wU5XctdBi/2oKu30hkomjceU8iv3 fspLT15SzNpusM/TPJIMmaj8NsLCFUq0AApCCkzR2osqwfN36S9mlYN+G74uq8L0Ur+a mzt/XXrIdfzWLkTlnVQuNg1tErCY2iY4F3YpltaE8L95/2cNt1GWdKGGvFTDiyJhJAnN q5w0LiPDG6UQllGWTaxOhBTPWEK7vl+o2NkTzxD+eg38cSZC71+CxUyKLaHXgCbSaSs8 VM4w== X-Gm-Message-State: ANoB5plz6ExZ7HnrK/L1gJO9dvlcEDL85JdX7nj0+AqHRf+L7OVZPXl9 aBJxLdj+Qyxm43C1vKXn+77V5ygZNZo+paPOuPzIk1xielWFi6ntI0tf00YiXtcqKJPR+cK9kL5 JiNPIt5A= X-Received: by 2002:a05:6102:7a5:b0:3b1:4b76:5b45 with SMTP id x5-20020a05610207a500b003b14b765b45mr11260896vsg.33.1670966647206; Tue, 13 Dec 2022 13:24:07 -0800 (PST) X-Google-Smtp-Source: AA0mqf64CG/Mk+OdQ+Wzys0ZhrHsEd+jUmuk0pNariTt00kB5IJdcroiFUNdSazVmeBA6bR85gzH2Q== X-Received: by 2002:a05:6102:7a5:b0:3b1:4b76:5b45 with SMTP id x5-20020a05610207a500b003b14b765b45mr11260885vsg.33.1670966646957; Tue, 13 Dec 2022 13:24:06 -0800 (PST) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id u2-20020a37ab02000000b006b615cd8c13sm8353296qke.106.2022.12.13.13.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 13:24:06 -0800 (PST) Message-ID: <03070a2e198b1e4a9f85c99bf52ecea567796b32.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Allow comparing vector types From: David Malcolm To: Antoni Boucher , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Cc: Guillaume Gomez Date: Tue, 13 Dec 2022 16:24:05 -0500 In-Reply-To: <1aec893b44d81c5558db3c3b2ac8b63e8c456469.camel@zoho.com> References: <1aec893b44d81c5558db3c3b2ac8b63e8c456469.camel@zoho.com> User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2022-12-12 at 21:31 -0500, Antoni Boucher via Jit wrote: > Hi. > This fixes bug 108078. > Thanks for the review. [...snip...] > diff --git a/gcc/jit/jit-recording.h b/gcc/jit/jit-recording.h > index 5d7c7177cc3..4ec0fff4843 100644 > --- a/gcc/jit/jit-recording.h > +++ b/gcc/jit/jit-recording.h > @@ -806,6 +806,15 @@ public: > =20 > void replay_into (replayer *) final override; > =20 > + virtual bool is_same_type_as (type *other) This would be better with a "final override" (and without the "virtual"). > + { > + vector_type *other_vec_type =3D other->dyn_cast_vector_type (); > + if (other_vec_type =3D=3D NULL) > + return false; > + return get_num_units () =3D=3D other_vec_type->get_num_units () > + && get_element_type () =3D=3D other_vec_type->get_element_type (); > + } > + OK for active branches with that nit fixed (though for gcc 10 you'd have to spell final and override as "FINAL" and "OVERRIDE" due to needing to be buildable with a C++98 compiler; not sure if gcc 10's libgccjit even has vector types though). [...snip...] Thanks for the patch Dave