From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id 7D6313858CDA; Tue, 30 Jan 2024 15:51:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D6313858CDA Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D6313858CDA Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706629876; cv=pass; b=k2g/WSSakm4OWb/Onlxd0z1mL7TycECQe4b4Liq5Qv5qyDmFmN6BjqnJcgCthCo+9YFYTlq4injfF1xhUbJAmTS7VySVGe5OU/rx5XRTL11+yjxvtvBJoLclygmzRAJWIZl2aVcvDzOzhBtkwpEgCnYjLiWnNbbgbMaFy4O/MnA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706629876; c=relaxed/simple; bh=nY6cxxI40oo9ITZkD84CiJ5E+qG4mN6si08ms7wkq30=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=UZ0SpZMbTtOnwUlqV/yun3qntCvLn0LRADR5j4IslKyZ5C88c17zOiSNpBV3N6w6l57/eZSEDgJ40CaQ5FF99Rcev6OAsWbb2bEB/hA7txnJ9WUbvANGt/jiLOc39vE+1UnJ7bHVp2qJNraGaXuI5pcGvIc7UfD4lt07Dhe64kw= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1706629859; cv=none; d=zohomail.com; s=zohoarc; b=H2QuQPQNenZ1JhJs3Mridx7BUqWVewUlW6tLLDx5WnZTnOCoor1dJd0zpgj29k+Aq8YuCpwOCzolmAjuq/nG69THookH0UZDq3B1fTVULjbhsk5l0iDp3iCE0987pH7pgm/OKyql5oR0w+/8qz4LKZdtpvKo1ULIHNApKhGgfZ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706629859; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=H1EVPPDkHVW09SOhj4lqE3e8QhIkACycNxg27J6C4wM=; b=PUIrFsxQidKTi/78k6AT+fCDVLut/ngn9RuCkJ8e1o0eARFx+Ckuygiezf/6C7wXDyDceFbRDHOqxbot+IACOVEqlV00KOC/W8dHjOp+2FCDecg//1cDc6bILbcuD5Z1Ac2b3jWTPLv3OsoQ8nu/9jU7Okcb3o8nra8Joi39HyI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1706629859; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Feedback-ID:Message-Id:Reply-To; bh=H1EVPPDkHVW09SOhj4lqE3e8QhIkACycNxg27J6C4wM=; b=P4LVWNZUUUQCNBY1vLkxC+ShODOHatEwMZQp7ZILn32f8eeyN2TkM6xbbN26BmTj DNHj63u9+4DR75S4WO2pe9h9JJ+wsoh5abtruZanTGFHOhY/1gdy2WvyTBkTt/Ar3My Qx5EL15PLWyOuxyN8r5rJDF86YNQ0XeCoA1m1UmQ= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1706629857211152.81897108257522; Tue, 30 Jan 2024 07:50:57 -0800 (PST) Message-ID: <036c7c0625a9bbb1a35e0d7d2ec4a553f88a6eec.camel@zoho.com> Subject: Re: [PATCH] libgccjit: Add ability to get CPU features From: Antoni Boucher To: David Malcolm , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Cc: Iain Buclaw Date: Tue, 30 Jan 2024 10:50:55 -0500 In-Reply-To: References: <8b0199d9835f568b7bcde41bf9432c21f604e489.camel@zoho.com> <755705e37731c4fbc3ab7eb1a96d8df0147bb002.camel@redhat.com> Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 Feedback-ID: rr0801122849bf66a688f5ad265ea11f0700004c329997c21ec5cd4f1e9be397fff7f3b671c510c035c9592b86:zu080112260725f20941c3e1c78b42049c0000eb75f7ce1b78e96549d7734e2ed2dab77ad918b003d16e72:rf08011232d8f2233afb4f74049f127243000036d10d3366cf69841bc2675024ffc67f7d92efd1b3beb36ba9a30e20855232cce1f71911:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: David: I'm unsure what to do here. It seems we cannot find a reviewer. Would it help if I show you the code in gccrs that is similar? Would it help if I ask someone from gccrs to review this code? On Sat, 2024-01-20 at 09:50 -0500, Antoni Boucher wrote: > CC-ing Iain in case they can do the review since it is based on how > they did it in the D frontend. > Could you please do the review? > Thanks! >=20 > On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote: > > On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote: > > > Hi. > > > This patch adds support for getting the CPU features in libgccjit > > > (bug > > > 112466) > > >=20 > > > There's a TODO in the test: > > > I'm not sure how to test that gcc_jit_target_info_arch returns > > > the > > > correct value since it is dependant on the CPU. > > > Any idea on how to improve this? > > >=20 > > > Also, I created a CStringHash to be able to have a > > > std::unordered_set. Is there any built-in way of > > > doing > > > this? > >=20 > > Thanks for the patch. > >=20 > > Some high-level questions: > >=20 > > Is this specifically about detecting capabilities of the host that > > libgccjit is currently running on? or how the target was configured > > when libgccjit was built? > >=20 > > One of the benefits of libgccjit is that, in theory, we support all > > of > > the targets that GCC already supports.=C2=A0 Does this patch change > > that, > > or > > is this more about giving client code the ability to determine > > capabilities of the specific host being compiled for? > >=20 > > I'm nervous about having per-target jit code.=C2=A0 Presumably there's = a > > reason that we can't reuse existing target logic here - can you > > please > > describe what the problem is.=C2=A0 I see that the ChangeLog has: > >=20 > > > * config/i386/i386-jit.cc: New file. > >=20 > > where i386-jit.cc has almost 200 lines of nontrivial code.=C2=A0 Where > > did > > this come from?=C2=A0 Did you base it on existing code in our source > > tree, > > making modifications to fit the new internal API, or did you write > > it > > from scratch?=C2=A0 In either case, how onerous would this be for other > > targets? > >=20 > > I'm not at expert at target hooks (or at the i386 backend), so if > > we > > do > > go with this approach I'd want someone else to review those parts > > of > > the patch. > >=20 > > Have you verified that GCC builds with this patch with jit *not* > > enabled in the enabled languages? > >=20 > > [...snip...] > >=20 > > A nitpick: > >=20 > > > +.. function:: const char * \ > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 gcc_jit_target_info_arch (gcc_jit_target_info > > > *info) > > > + > > > +=C2=A0=C2=A0 Get the architecture of the currently running CPU. > >=20 > > What does this string look like? > > How long does the pointer remain valid? > >=20 > > Thanks again; hope the above makes sense > > Dave > >=20 >=20