From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 94585385840A for ; Wed, 10 Jan 2024 15:19:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94585385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 94585385840A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704900001; cv=none; b=mFHyZcpluHNwEaX3+gNQmxuWPUXQiuT0CkFYBZxjHZyCUrUcK2ZsTG8BgmftEPZwnobQUtAEbXMQp9WYLVykURoCCVCMq9IwFLaBIFLI+bQejxnQnVbgAz4mnQ6dP2o55u1eE28KZh2Zup/ayl+yFEcK9IGfLxpkSr7C8SRgkjM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704900001; c=relaxed/simple; bh=Q8/X6Zce6Gc/Gyl9O/Bc/70jbtKjysHBe2CvNtteinc=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=PQ7mZ7iuA8/B+PAtYztbBkQ4phTJXWfudhk2zuKP+uz3bc2bQckGDG02Eu7s5ZI5hS8pC+3NA2MhzHQ5Ts+ILT8uT1Z5fKw1JigbPDdwXlK8OyL4SgD+CIO8NbizzUpGTdTSFCYBcODcAx4VcPOFDajXEnXZ3Lu78hVQ1kUlAzE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704899998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e4RdEqWVBNj4Li3cj+66rdlphFc3h/P7jLPZNGG3Nr0=; b=EQ1+U7G/Iz9GMyOj03eSgikj7ltIptUr+pPNCT8CjrfmN+cj/sdn4/5dceyCqhiXP7hQIN HeSz7M/dMsA0/63jqpSgJLh/N/ptlqpgsjF/sd/KzMR52c2ywfCublpN/6J8JwU6goSRMq khOar1l80oB/4GyE4wOwGjCfmn/IDSY= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-zLKak-1aPzW8H9ZRV4tnUA-1; Wed, 10 Jan 2024 10:19:57 -0500 X-MC-Unique: zLKak-1aPzW8H9ZRV4tnUA-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-680c7ce15a0so48984396d6.1 for ; Wed, 10 Jan 2024 07:19:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704899996; x=1705504796; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e4RdEqWVBNj4Li3cj+66rdlphFc3h/P7jLPZNGG3Nr0=; b=IUHeUx5ojmqdu0GJC73KxlVZtmHPJV7wksWASDhQQd6/RswvTwqPWF1wbkpWYoe+HK fC6Me7ZqaPQlQMCJYQWkMoHcvz9BR1EbPo8fDMkTTgnRwKh7i2tJyQXMR0uct/c8NfUV xVDu9T4X7LPEAhhdN/HvzTmsjpIrq8PtomTi71vQMD/UAaZh9rTmMxXjRrv8085dJ54+ zPUzJZ40B92LiWDDVR+z2duO5oRmOrObWNeoBS/XBYD7mJ3r3w83YEm1eiow9xPCpDe5 SKBTfD+mxHaJRZJyvdv/ZfR3Y0noXKw13r+q8c2i/aLbIsveoEJE7Nid7d+SXKh9yfUU mH/w== X-Gm-Message-State: AOJu0YynUxTTgcelg8fzq+ES+3sjYSAK0gTLNsVnf5of5Dd9kAk8LzGe 4DdTNZZ55In0nlHxoi956OPJL14IlOEiGN1dlslG+IXTgI/WdPX6MO27FxJV8aAlKrgfijdZCBt JUrRFVVfQeSwvPnk= X-Received: by 2002:ad4:5f05:0:b0:67f:67de:5d00 with SMTP id fo5-20020ad45f05000000b0067f67de5d00mr1352683qvb.46.1704899996420; Wed, 10 Jan 2024 07:19:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IG53z116l62X02c04lwewVrhh92RubWstzpOVhD6FDnOmqfwE31Wli5KGUcXrJY+wD4Nqhjhw== X-Received: by 2002:ad4:5f05:0:b0:67f:67de:5d00 with SMTP id fo5-20020ad45f05000000b0067f67de5d00mr1352674qvb.46.1704899996155; Wed, 10 Jan 2024 07:19:56 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id ev20-20020a0562140a9400b00680c81edc44sm1774337qvb.38.2024.01.10.07.19.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 07:19:55 -0800 (PST) Message-ID: <03e4a5d4e0b181a46f6c76e643503d54bf508b0c.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Fix GGC segfault when using -flto From: David Malcolm To: Antoni Boucher , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Wed, 10 Jan 2024 10:19:54 -0500 In-Reply-To: References: <459954b377768b7a0d79dd9d99328b45c66e4fa0.camel@redhat.com> <9738ef0c44d5f5505607c6678d23683aaba2c72f.camel@redhat.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2023-12-11 at 19:20 -0500, Antoni Boucher wrote: > I'm not sure how to do this. I tried the following commands, but this > fails even on master: >=20 > ../../gcc/configure --enable-host-shared --enable- > languages=3Dc,jit,c++,fortran,objc,lto --enable-checking=3Drelease -- > disable-werror --prefix=3D/opt/gcc >=20 > make bootstrap -j24 > make -k check -j24 >=20 > From what I can understand, the unexpected failures are in g++: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=3D=3D=3D g++ Summary =3D=3D=3D >=20 > # of expected passes=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A072790 > # of unexpected failures=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A01 > # of expected failures=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A01011 > # of unsupported tests=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A03503 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=3D=3D=3D g++ Summary =3D=3D=3D >=20 > # of expected passes=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A04750 > # of unexpected failures=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A02= 7 > # of expected failures=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A016 > # of unsupported tests=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A043 >=20 >=20 > Am I doing something wrong? I normally do a pair of bootstrap/tests: a "control" build with a pristine copy of the source tree, and an "experiment" build containing the patch(s) of interest, then compare the results. FWIW given that each one takes 2 hours on my machine, I normally just do one control build on a Monday, rebase all my working copies to that revision, and then use that control build throughout the week for comparison when testing patches. I can have a go at testing an updated patch if you like; presumably the latest version is this one: https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638841.html right? Dave >=20 > On Fri, 2023-12-01 at 12:49 -0500, David Malcolm wrote: > > On Thu, 2023-11-30 at 17:13 -0500, Antoni Boucher wrote: > > > Here's the updated patch. > > > The failure was due to the test being in the test array while it > > > should > > > not have been there since it changes the context. > >=20 > > Thanks for the updated patch. > >=20 > > Did you do a full bootstrap and regression test with this one, or > > do > > you want me to? > >=20 > > Dave > >=20 >=20