From: Antoni Boucher <bouanto@zoho.com>
To: David Malcolm <dmalcolm@redhat.com>, Andrew Pinski <pinskia@gmail.com>
Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libgccjit: Add support for machine-dependent builtins
Date: Wed, 10 Jan 2024 18:58:15 -0500 [thread overview]
Message-ID: <0f44d7bb2d4baa961112e164cefa1bd0a8ec0b1c.camel@zoho.com> (raw)
In-Reply-To: <f9385da59879754bb0f414ff0a5c2bf9a28d279b.camel@redhat.com>
Here it is: https://gcc.gnu.org/pipermail/jit/2023q4/001725.html
On Wed, 2024-01-10 at 18:44 -0500, David Malcolm wrote:
> On Wed, 2024-01-10 at 18:29 -0500, Antoni Boucher wrote:
> > David: Ping in case you missed this patch.
>
> For some reason it's not showing up in patchwork (or, at least, I
> can't
> find it there). Do you have a URL for it there?
>
> Sorry about this
> Dave
>
> >
> > On Sat, 2023-02-11 at 17:37 -0800, Andrew Pinski wrote:
> > > On Sat, Feb 11, 2023 at 4:31 PM Antoni Boucher via Gcc-patches
> > > <gcc-patches@gcc.gnu.org> wrote:
> > > >
> > > > Hi.
> > > > This patch adds support for machine-dependent builtins in
> > > > libgccjit
> > > > (bug 108762).
> > > >
> > > > There are two things I don't like in this patch:
> > > >
> > > > 1. There are a few functions copied from the C frontend
> > > > (common_mark_addressable_vec and a few others).
> > > >
> > > > 2. Getting a target builtin only works from the second
> > > > compilation
> > > > since the type information is recorded at the first
> > > > compilation.
> > > > I
> > > > couldn't find a way to get the builtin data without using the
> > > > langhook.
> > > > It is necessary to get the type information for type checking
> > > > and
> > > > instrospection.
> > > >
> > > > Any idea how to fix these issues?
> > >
> > > Seems like you should do this patch in a few steps; that is split
> > > it
> > > up.
> > > Definitely split out GCC_JIT_TYPE_BFLOAT16 support.
> > > I also think the vector support should be in a different patch
> > > too.
> > >
> > > Splitting out these parts would definitely make it easier for
> > > review
> > > and make incremental improvements.
> > >
> > > Thanks,
> > > Andrew Pinski
> > >
> > >
> > >
> > > >
> > > > Thanks for the review.
> >
>
next prev parent reply other threads:[~2024-01-10 23:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 0:30 Antoni Boucher
2023-02-12 0:32 ` Antoni Boucher
2023-02-12 1:37 ` Andrew Pinski
2023-11-23 22:17 ` Antoni Boucher
2023-11-23 22:21 ` Antoni Boucher
2024-01-10 23:29 ` Antoni Boucher
2024-01-10 23:44 ` David Malcolm
2024-01-10 23:58 ` Antoni Boucher [this message]
2024-02-08 13:59 ` Antoni Boucher
2024-02-15 14:32 ` Antoni Boucher
2024-02-29 15:34 ` Antoni Boucher
2024-04-19 12:35 ` Antoni Boucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f44d7bb2d4baa961112e164cefa1bd0a8ec0b1c.camel@zoho.com \
--to=bouanto@zoho.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).