From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20180 invoked by alias); 19 Mar 2014 19:31:24 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 20086 invoked by uid 89); 19 Mar 2014 19:31:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.98.1 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Message-ID: <1395257376.28037.110.camel@surprise> Subject: Re: [RFA jit v2 1/2] introduce class toplev From: David Malcolm To: Tom Tromey Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Wed, 01 Jan 2014 00:00:00 -0000 In-Reply-To: <87d2hif4ar.fsf@fleche.redhat.com> References: <1395251539-16155-1-git-send-email-tromey@redhat.com> <1395251539-16155-2-git-send-email-tromey@redhat.com> <87d2hif4ar.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-SW-Source: 2014-q1/txt/msg00091.txt.bz2 On Wed, 2014-03-19 at 12:10 -0600, Tom Tromey wrote: > >>>>> "Tom" == Tom Tromey writes: > > Tom> This patch introduces a new "class toplev" and changes toplev_main and > Tom> toplev_finalize to be methods of this class. Additionally, now the > Tom> timevars are automatically stopped when the object is destroyed. This > Tom> cleans up "compile" a bit and makes it simpler to reuse the toplev > Tom> logic in other code. > > David asked me off-list to rename the field in class toplev, so here's a > new patch that does this. Thanks! (yes, I greatly prefer having member data of a class to have a "m_" prefix, and for the ctor params to have equivalent names, without the prefix, which this patch does, for "toplev"). > Tom > > commit 66f92863ef55c26f673d02dd39027f340940a3bf > Author: Tom Tromey > Date: Tue Mar 18 08:07:40 2014 -0600 > > introduce class toplev > > This patch introduces a new "class toplev" and changes toplev_main and > toplev_finalize to be methods of this class. Additionally, now the > timevars are automatically stopped when the object is destroyed. This > cleans up "compile" a bit and makes it simpler to reuse the toplev > logic in other code. OK. Are you able to push this to my branch, or do you need me to do this?