public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
* [jit] Ensure dlerror failures lead to the overall "compilation" failing
@ 2014-01-01  0:00 David Malcolm
  0 siblings, 0 replies; only message in thread
From: David Malcolm @ 2014-01-01  0:00 UTC (permalink / raw)
  To: jit, gcc-patches; +Cc: David Malcolm

Committed to branch dmalcolm/jit:

gcc/jit/
	* internal-api.c (gcc::jit::playback::context::compile): Put
	any output of dlerror through the add_error method, rather
	than merely printing it to stderr, so that the error is also
	recorded on the context.
---
 gcc/jit/ChangeLog.jit  | 7 +++++++
 gcc/jit/internal-api.c | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/gcc/jit/ChangeLog.jit b/gcc/jit/ChangeLog.jit
index d4ed6cf..ccf8a10 100644
--- a/gcc/jit/ChangeLog.jit
+++ b/gcc/jit/ChangeLog.jit
@@ -1,3 +1,10 @@
+2014-04-25  David Malcolm  <dmalcolm@redhat.com>
+
+	* internal-api.c (gcc::jit::playback::context::compile): Put
+	any output of dlerror through the add_error method, rather
+	than merely printing it to stderr, so that the error is also
+	recorded on the context.
+
 2014-03-19  Tom Tromey  <tromey@redhat.com>
 
 	* internal-api.c (compile): Use auto_timevar.
diff --git a/gcc/jit/internal-api.c b/gcc/jit/internal-api.c
index f9f4d8e..f45595e 100644
--- a/gcc/jit/internal-api.c
+++ b/gcc/jit/internal-api.c
@@ -3771,7 +3771,7 @@ compile ()
 
     handle = dlopen (m_path_so_file, RTLD_NOW | RTLD_LOCAL);
     if ((error = dlerror()) != NULL)  {
-      fprintf(stderr, "%s\n", error);
+      add_error (NULL, "%s", error);
     }
     if (handle)
       result_obj = new result (handle);
-- 
1.8.5.3

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-04-25 20:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-01  0:00 [jit] Ensure dlerror failures lead to the overall "compilation" failing David Malcolm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).