public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org
Cc: David Malcolm <dmalcolm@redhat.com>
Subject: [PATCH 0/2] Refactoring of timevar API
Date: Thu, 01 Jan 2015 00:00:00 -0000	[thread overview]
Message-ID: <1438379154-9333-1-git-send-email-dmalcolm@redhat.com> (raw)

The attached two patches correspond to the first patch:
 "[PATCH 01/16] gcc: Generalization of timevar API; add gcc_jit_timer interface"
   https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00122.html
of the 16-patch kit I posted in June:
  https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00116.html

For ease of review, I've broken it up into two patches:

  * the first patch contains the changes to the core gcc directory
    (requires review)

  * the second patch contains the changes to the gcc/jit
    subdirectory (which I can self-approve).

That said, both patches require each other and would be
committed as one.

These patches are useful without needing the 15 followup patches,
in that they allow jit client code to control timing, leading to
more meaningful benchmark results).

For further motivation, see:
  https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00122.html

(as well as the split into a pair of patches, there are some
small changes to the jit side relative to that earlier patch).

Successfully bootstrapped & regrtested the combination of the two
patches on x86_64-pc-linux-gnu (Fedora 20) with all languages
other than ada [1].

jit.sum goes from 8494 to 8514 passes.

Are the non-jit parts OK for trunk?

[1] I ran into:
 a-chlat1.ads:16:08: warning: unrecognized pragma "Compiler_Unit_Warning"
on ada, which is apparently unrelated.

David Malcolm (2):
  gcc parts of timer refactoring
  jit: add timing API

 gcc/jit/docs/topics/compatibility.rst              |  21 ++
 gcc/jit/docs/topics/contexts.rst                   |   3 +-
 gcc/jit/docs/topics/index.rst                      |   1 +
 gcc/jit/docs/topics/performance.rst                | 240 ++++++++++++++++++++
 gcc/jit/jit-playback.c                             |  11 +-
 gcc/jit/jit-playback.h                             |   2 +
 gcc/jit/jit-recording.c                            |   2 +
 gcc/jit/jit-recording.h                            |   7 +
 gcc/jit/libgccjit++.h                              | 117 ++++++++++
 gcc/jit/libgccjit.c                                | 109 +++++++++
 gcc/jit/libgccjit.h                                |  84 +++++++
 gcc/jit/libgccjit.map                              |  12 +
 gcc/main.c                                         |   2 +-
 gcc/testsuite/jit.dg/test-benchmark.c              |  20 +-
 .../jit.dg/test-error-gcc_jit_timer_pop-mismatch.c |  22 ++
 .../jit.dg/test-error-gcc_jit_timer_pop-too-many.c |  21 ++
 gcc/timevar.c                                      | 247 ++++++++++++++++++---
 gcc/timevar.def                                    |   2 +
 gcc/timevar.h                                      |  35 ++-
 gcc/toplev.c                                       |  18 +-
 gcc/toplev.h                                       |   4 +-
 21 files changed, 926 insertions(+), 54 deletions(-)
 create mode 100644 gcc/jit/docs/topics/performance.rst
 create mode 100644 gcc/testsuite/jit.dg/test-error-gcc_jit_timer_pop-mismatch.c
 create mode 100644 gcc/testsuite/jit.dg/test-error-gcc_jit_timer_pop-too-many.c

-- 
1.8.5.3

             reply	other threads:[~2015-07-31 21:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-01  0:00 David Malcolm [this message]
2015-01-01  0:00 ` [PATCH 2/2] jit: add timing API David Malcolm
2015-01-01  0:00 ` [PATCH 1/2] gcc parts of timer refactoring David Malcolm
2015-01-01  0:00   ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438379154-9333-1-git-send-email-dmalcolm@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jit@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).