public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH 2/2] jit: use FINAL and OVERRIDE throughout
Date: Fri, 01 Jan 2016 00:00:00 -0000	[thread overview]
Message-ID: <1463171396.11310.93.camel@redhat.com> (raw)
In-Reply-To: <1462552846-17096-2-git-send-email-dmalcolm@redhat.com>

On Fri, 2016-05-06 at 12:40 -0400, David Malcolm wrote:
> Mark most virtual functions in gcc/jit as being FINAL OVERRIDE.
> gcc::jit::recording::lvalue::access_as_rvalue is the sole OVERRIDE
> that isn't a FINAL.
> 
> Successfully bootstrapped&regrtested on x86_64-pc-linux-gnu.
> 
> I can self-approve this, but as asked in patch 1,
> does "final" imply "override"?  Is "final override" a tautology?

http://stackoverflow.com/questions/29412412/does-final-imply-override s
ays that "final override" is *not* tautologous.

I've committed this jit patch to trunk as r236223.

Dave

  reply	other threads:[~2016-05-13 20:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-01  0:00 [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h David Malcolm
2016-01-01  0:00 ` [PATCH 2/2] jit: use FINAL and OVERRIDE throughout David Malcolm
2016-01-01  0:00   ` David Malcolm [this message]
2016-01-01  0:00 ` [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h Jakub Jelinek
2016-01-01  0:00   ` CONSTEXPR macro (was "Re: [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h") David Malcolm
2016-01-01  0:00     ` Jakub Jelinek
2016-01-01  0:00 ` [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h Pedro Alves
2016-01-01  0:00   ` Pedro Alves
2016-01-01  0:00     ` Trevor Saunders
2016-01-01  0:00       ` Move OVERRIDE/FINAL from gcc/coretypes.h to include/ansidecl.h (was: Re: [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h) Pedro Alves
2016-01-01  0:00         ` Move OVERRIDE/FINAL from gcc/coretypes.h to include/ansidecl.h Bernd Schmidt
2016-01-01  0:00           ` Pedro Alves
2016-01-01  0:00             ` Bernd Schmidt
2016-01-01  0:00               ` Pedro Alves
2016-01-01  0:00                 ` [wwwdocs, coding conventions] Mention OVERRIDE/FINAL David Malcolm
2016-01-01  0:00                   ` Pedro Alves
2017-01-01  0:00                   ` Gerald Pfeifer
2017-01-01  0:00                     ` Trevor Saunders
2017-01-01  0:00                   ` Gerald Pfeifer
2016-01-01  0:00       ` [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h Pedro Alves
2016-01-01  0:00   ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463171396.11310.93.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jit@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).