From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 96AC13858D38 for ; Wed, 24 Jan 2024 17:34:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 96AC13858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 96AC13858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706117656; cv=none; b=qfyZbA1F8G1ObMbU9/cpjnx4wylzjIZtqLZz0yV2v8kGVhNjZ7cq1vSNzCt09TOVis0KOkYpOXdYu9sHSwA8XdZybOpjdy6dnOjW4yifqB4FUZ6xXIuJ3EvmnYsaS4iSKF8x/ZS8tcfFXuKAWKfX8fwrytjkPO7ygzNgb2xcpGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706117656; c=relaxed/simple; bh=Y7CUQzD7adtCZQkShN9kSmsRCksQJDbaRWFENyJoGL8=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=JGGd8X6dsdLwjXcZNU2Uf3pLl80tWA71MQbcwdCFgMgIAeVDDgJ4RA7aWyp42FTghRQmZ+ZexbGvYY/DEHYyAMCe+T3EkWeCBSrdYfPenSFGxzHGx0vZptRxSXMsHNfWD9+OwsI1m6QKBjsX+mIFRSUd3dfw0rogIixYTv31q7I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706117654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dNTPXPqmtzlmlEuaFvqz95sbkTQhA4X6kU3BF2LfNcU=; b=R81E3j0qMNO4MRe16TCWWxhHOVYfsV11pyRJQ3RcVuM+vvXZDvv7diWnDHBfK9gDFwQGXn rOiAtN6v/FNb8TH7QIgltza/TdW/S7Exu86SVtg4nvtA5JsA/IV1Cc10xS8SEt7XriyFKp 2WJ5m5D5fF1D8l3toAwgViN+UowcqAE= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-17-B_sRQZl_OaOwI3IWADq7bA-1; Wed, 24 Jan 2024 12:33:55 -0500 X-MC-Unique: B_sRQZl_OaOwI3IWADq7bA-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-78389fe6defso981063085a.1 for ; Wed, 24 Jan 2024 09:33:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706117635; x=1706722435; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dNTPXPqmtzlmlEuaFvqz95sbkTQhA4X6kU3BF2LfNcU=; b=wcpXpGZ6pT9d0MQZT983FAx6oKqf2u9yZ2oLPScYgu0r2Dc/3xQApPCbcO2dV1MwBr Llc0PMrYxChkNNgAcgENMdGxTIjAk27DW0WIk6CM3pnxjxxDQY6xPXBdyraHYp9QSZPL 4wnevXJl8ecV/yA05v9EatrHJfoxSZA5xZJOpVThl7tJeITGpeTZkrXOInccNo+El5Wt q+KG57d4Zo3bPLSxe5uRG3L71LmPBt6jeyb+B9+SAeLNDZWhYaQwltyNXVccpZTX0Wsu ldbGwUR8m6HxSXhDzASf2iS+3ylPMUDViEdKmAZdRJ69/Ga9kAft+ESXs5ZnlbEdBSVV 4z4Q== X-Gm-Message-State: AOJu0YzH5uAe/VkK4O9+4U6yQJNu07eZCZB/pFQGirgbN/KLjj8H0uer W2dybERIF34qSelaLd9K0urJpdmfbQn28rkB2AOgqTmWuWoQw6XpInlMmiG/NDBfgfxhECWzAa+ M+kDJ8EUOmIk+pvIvzMTVxEI8aY0wmw/G7dN4uiY2EXAC X-Received: by 2002:ae9:f506:0:b0:783:2c45:2825 with SMTP id o6-20020ae9f506000000b007832c452825mr7895161qkg.93.1706117635010; Wed, 24 Jan 2024 09:33:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHftN3RpJHxJ49vA2di/rrbyDFSEYSBy8R+pboaFk3nW84QC4sF11qN53mTducbtFqHDfwGBQ== X-Received: by 2002:ae9:f506:0:b0:783:2c45:2825 with SMTP id o6-20020ae9f506000000b007832c452825mr7895158qkg.93.1706117634811; Wed, 24 Jan 2024 09:33:54 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id j26-20020a05620a001a00b00783b6da58a9sm538723qki.39.2024.01.24.09.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 09:33:54 -0800 (PST) Message-ID: <14705a2385028450967d25cb6387892d2946393e.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Add convert vector From: David Malcolm To: Antoni Boucher , "jit@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Date: Wed, 24 Jan 2024 12:33:53 -0500 In-Reply-To: References: User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2023-12-21 at 16:01 -0500, Antoni Boucher wrote: > Hi. > This patch adds the support for the convert vector internal function. Thanks for the patch. > I'll need to double-check that making the decl a register is > necessary. I confess I don't know anything about this aspect of the patch, but presumably you have this working within the rustc backend as well as in the testcase. Am I right in thinking that this is an elementwise conversion? Might be good to specify this in the docs and header file. Otherwise looks good to me (with usual comment about updating the ABI numbering as necessary) Thanks Dave