From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62482 invoked by alias); 14 Oct 2016 21:28:08 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 62453 invoked by uid 89); 14 Oct 2016 21:28:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=carefully, website, our, reader X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Message-ID: <1476480483.10766.46.camel@redhat.com> Subject: [wwwdocs, coding conventions] Mention OVERRIDE/FINAL From: David Malcolm To: Pedro Alves , Bernd Schmidt , Trevor Saunders Cc: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org, Gerald Pfeifer Date: Fri, 01 Jan 2016 00:00:00 -0000 In-Reply-To: <0c78b409-efcc-3c49-4323-699e7ecfb6a0@redhat.com> References: <1462552846-17096-1-git-send-email-dmalcolm@redhat.com> <8ce94f18-421f-9466-85cf-e17d9caee151@redhat.com> <20160506183345.GK3628@ball> <5b2de202-c6bd-f8fc-3407-45a40ddfe62c@redhat.com> <014f88ec-909b-db46-1213-e9dbb8f14ee4@redhat.com> <0c78b409-efcc-3c49-4323-699e7ecfb6a0@redhat.com> Content-Type: multipart/mixed; boundary="=-nAxpe8PZ4yXu2FPIqLdX" Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 14 Oct 2016 21:28:05 +0000 (UTC) X-SW-Source: 2016-q4/txt/msg00005.txt.bz2 --=-nAxpe8PZ4yXu2FPIqLdX Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 801 On Fri, 2016-10-14 at 16:27 +0100, Pedro Alves wrote: > On 10/12/2016 03:13 PM, Bernd Schmidt wrote: > > On 10/12/2016 04:09 PM, Pedro Alves wrote: > > > > > > Thanks. Here's a follow up patch that I was just testing. > > > > > > Need this if building with "g++ -std=gnu++11", with gcc < 4.7. > > > > Lovely. That's ok too if the other one goes in. > > FYI, I pushed these in now. I also bootstrapped with the > jit included in the selected languages, and hacked the > jit code a bit to trigger the problems OVERRIDE intends to > catch, just to make sure it still works. > > Thanks, > Pedro Alves I propose that we update our coding conventions to mention the OVERRIDE and FINAL macros in the paragraph that discusses virtual funcs. The attached patch (to the website) does so. OK to commit? --=-nAxpe8PZ4yXu2FPIqLdX Content-Disposition: attachment; filename="www-use-OVERRIDE-and-FINAL.patch" Content-Type: text/x-patch; name="www-use-OVERRIDE-and-FINAL.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 Content-length: 1107 SW5kZXg6IGh0ZG9jcy9jb2Rpbmdjb252ZW50aW9ucy5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvZ2NjL3d3d2RvY3MvaHRk b2NzL2NvZGluZ2NvbnZlbnRpb25zLmh0bWwsdgpyZXRyaWV2aW5nIHJldmlz aW9uIDEuNzcKZGlmZiAtdSAtcCAtcjEuNzcgY29kaW5nY29udmVudGlvbnMu aHRtbAotLS0gaHRkb2NzL2NvZGluZ2NvbnZlbnRpb25zLmh0bWwJMTggU2Vw IDIwMTYgMTM6NTU6MTcgLTAwMDAJMS43NworKysgaHRkb2NzL2NvZGluZ2Nv bnZlbnRpb25zLmh0bWwJMTQgT2N0IDIwMTYgMjE6MjI6NDQgLTAwMDAKQEAg LTkwMiw3ICs5MDIsMTAgQEAgSXRzIHVzZSB3aXRoIGRhdGEtY2Fycnlpbmcg Y2xhc3NlcyBpcyBtbwogPHA+CiBUaGluayBjYXJlZnVsbHkgYWJvdXQgdGhl IHNpemUgYW5kIHBlcmZvcm1hbmNlIGltcGFjdAogb2YgdmlydHVhbCBmdW5j dGlvbnMgYW5kIHZpcnR1YWwgYmFzZXMKLWJlZm9yZSB1c2luZyB0aGVtLgor YmVmb3JlIHVzaW5nIHRoZW0uICBJZiB5b3UgZG8gdXNlIHZpcnR1YWwgZnVu Y3Rpb25zLCB1c2UgdGhlCis8Y29kZT5PVkVSUklERTwvY29kZT4gYW5kIDxj b2RlPkZJTkFMPC9jb2RlPiBtYWNyb3MgZnJvbQorPGNvZGU+aW5jbHVkZS9h bnNpZGVjbC5oPC9jb2RlPiB0byBhbm5vdGF0ZSB0aGUgY29kZSBmb3IgYSBo dW1hbiByZWFkZXIsCithbmQgdG8gYWxsb3cgc3VmZmljaWVudGx5IG1vZGVy biBDKysgY29tcGlsZXJzIHRvIGRldGVjdCBtaXN0YWtlcy4KIDwvcD4KIAog PHA+Cg== --=-nAxpe8PZ4yXu2FPIqLdX--